You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "CxHsin (via GitHub)" <gi...@apache.org> on 2026/08/21 05:48:19 UTC

[PR] fix(cli): align TUI input and transcript flow [maka]

CxHsin opened a new pull request, #3374:
URL: https://github.com/apache/maka/pull/3374

   ## Summary
   
   Fixes #3361
   
   Align the TUI input with the terminal edge, add a consistent one-cell gutter around transcript entries, and trim trailing blank rows before applying the transcript separator. This keeps tool stacks evenly spaced after assistant Markdown ends with a blank paragraph.
   
   ## Verification
   
   - `node --test packages/cli/dist/__tests__/pi-transcript.test.js`
   - `npx biome check packages/cli/src/pi-transcript.ts packages/cli/src/pi-tui-runner.ts packages/cli/src/__tests__/pi-transcript.test.ts`
   - `npm --workspace maka-agent test` ran the full CLI suite. The new transcript regression passed; 8 pre-existing Windows-environment failures remain: two SIGTERM expectations and six Runtime Host service cases blocked by `fsync`/symlink permissions.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex (GPT-5) implemented the focused TUI layout and transcript-spacing changes, added the regression test, and ran verification. The commit includes `Generated-by: Codex (GPT-5)`.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(cli): align TUI input and transcript flow [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #3374:
URL: https://github.com/apache/maka/pull/3374#issuecomment-5365896430

   The fix is nice and clean. Could we have a before after compirison graph in the PR body?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(cli): align TUI input and transcript flow [maka]

Posted by "CxHsin (via GitHub)" <gi...@apache.org>.
CxHsin commented on PR #3374:
URL: https://github.com/apache/maka/pull/3374#issuecomment-5366357162

   before:
   <img width="490" height="116" alt="image" src="https://github.com/user-attachments/assets/c9c85948-fc88-4e53-8101-c0a774d10b03" />
   <img width="906" height="278" alt="image" src="https://github.com/user-attachments/assets/c58b5da7-bf7d-41c4-af2d-1e2c75ed27dc" />
   
   
   after:
   <img width="557" height="109" alt="image" src="https://github.com/user-attachments/assets/19d68e8a-c265-45c7-aefe-9befe0faf601" />
   <img width="991" height="297" alt="image" src="https://github.com/user-attachments/assets/b3fa7122-8299-4f68-b3c5-bc7ac343406f" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(cli): align TUI input and transcript flow [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #3374:
URL: https://github.com/apache/maka/pull/3374


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org