You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:22:22 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #38400: [SPARK-40921][SQL] Add WHEN NOT MATCHED BY SOURCE clause to MERGE INTO
cloud-fan commented on code in PR #38400:
URL: https://github.com/apache/spark/pull/38400#discussion_r1008123172
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -602,6 +602,24 @@
],
"sqlState" : "42000"
},
+ "NON_LAST_MATCHED_CLAUSE_OMIT_CONDITION" : {
+ "message" : [
+ "When there are more than one MATCHED clauses in a MERGE statement, only the last MATCHED clause can omit the condition."
+ ],
+ "sqlState" : "42000"
+ },
+ "NON_LAST_NOT_MATCHED_BY_SOURCE_CLAUSE_OMIT_CONDITION" : {
+ "message" : [
+ "When there are more than one NOT MATCHED BY SOURCE clauses in a MERGE statement, only the last NOT MATCHED BY SOURCE clause can omit the condition."
+ ],
+ "sqlState" : "42000"
+ },
+ "NON_LAST_NOT_MATCHED_CLAUSE_OMIT_CONDITION" : {
Review Comment:
is it more accurate to name it `NON_LAST_NOT_MATCHED_BY_TARGET_CLAUSE_OMIT_CONDITION `
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -602,6 +602,24 @@
],
"sqlState" : "42000"
},
+ "NON_LAST_MATCHED_CLAUSE_OMIT_CONDITION" : {
+ "message" : [
+ "When there are more than one MATCHED clauses in a MERGE statement, only the last MATCHED clause can omit the condition."
+ ],
+ "sqlState" : "42000"
+ },
+ "NON_LAST_NOT_MATCHED_BY_SOURCE_CLAUSE_OMIT_CONDITION" : {
+ "message" : [
+ "When there are more than one NOT MATCHED BY SOURCE clauses in a MERGE statement, only the last NOT MATCHED BY SOURCE clause can omit the condition."
+ ],
+ "sqlState" : "42000"
+ },
+ "NON_LAST_NOT_MATCHED_CLAUSE_OMIT_CONDITION" : {
Review Comment:
is it more accurate to name it `NON_LAST_NOT_MATCHED_BY_TARGET_CLAUSE_OMIT_CONDITION`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org