You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ra...@apache.org on 2026/01/27 12:36:31 UTC

(arrow) branch main updated: GH-47692: [CI][Python] Do not fallback to return 404 if wheel is found on emscripten jobs (#49007)

This is an automated email from the ASF dual-hosted git repository.

raulcd pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 515f724690 GH-47692: [CI][Python] Do not fallback to return 404 if wheel is found on emscripten jobs (#49007)
515f724690 is described below

commit 515f7246901f6ad6b630d92f5136959c3251b694
Author: Raúl Cumplido <ra...@gmail.com>
AuthorDate: Tue Jan 27 13:36:24 2026 +0100

    GH-47692: [CI][Python] Do not fallback to return 404 if wheel is found on emscripten jobs (#49007)
    
    ### Rationale for this change
    
    When looking for the wheel the script was falling back to returning a 404 even when the wheel was found:
    ```
     + python scripts/run_emscripten_tests.py dist/pyarrow-24.0.0.dev31-cp312-cp312-pyodide_2024_0_wasm32.whl --dist-dir=/pyodide --runtime=chrome
    127.0.0.1 - - [27/Jan/2026 01:14:50] code 404, message File not found
    ```
    Timing out the job and failing.
    
    ### What changes are included in this PR?
    
    Correct logic and only return 404 if the file requested wasn't found.
    
    ### Are these changes tested?
    
    Yes via archery
    
    ### Are there any user-facing changes?
    
    No
    * GitHub Issue: #47692
    
    Authored-by: Raúl Cumplido <ra...@gmail.com>
    Signed-off-by: Raúl Cumplido <ra...@gmail.com>
---
 python/scripts/run_emscripten_tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/scripts/run_emscripten_tests.py b/python/scripts/run_emscripten_tests.py
index 53d3dd52bd..406dfc54e4 100644
--- a/python/scripts/run_emscripten_tests.py
+++ b/python/scripts/run_emscripten_tests.py
@@ -45,7 +45,7 @@ class TemplateOverrider(http.server.SimpleHTTPRequestHandler):
             self.end_headers()
             with PYARROW_WHEEL_PATH.open(mode="rb") as wheel:
                 self.copyfile(wheel, self.wfile)
-        if self.path.endswith("/test.html"):
+        elif self.path.endswith("/test.html"):
             body = b"""
                 <!doctype html>
                 <html>