You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2017/12/07 12:05:11 UTC
Re: Review Request 63861: Windows: Updated networking doc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 12:05 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Changes
-------
Rebased.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description
-------
The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.
Diffs (updated)
-----
docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983
Diff: https://reviews.apache.org/r/63861/diff/4/
Changes: https://reviews.apache.org/r/63861/diff/3-4/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 63861: Windows: Updated networking doc.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Dec. 7, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote:
> > docs/networking.md
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/63861/diff/4/?file=1910379#file1910379line120>
> >
> > nit: s/is/are
fixed
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review193174
-----------------------------------------------------------
On Dec. 7, 2017, 10:05 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 10:05 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
>
>
> Diffs
> -----
>
> docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983
>
>
> Diff: https://reviews.apache.org/r/63861/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63861: Windows: Updated networking doc.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/#review193174
-----------------------------------------------------------
docs/networking.md
Lines 120 (patched)
<https://reviews.apache.org/r/63861/#comment271693>
nit: s/is/are
- Andrew Schwartzmeyer
On Dec. 7, 2017, 4:05 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63861/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 4:05 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The networking docs now describe how the Docker network modes in the
> `Network` enum work on Windows, since the enum only has Linux network
> modes.
>
>
> Diffs
> -----
>
> docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983
>
>
> Diff: https://reviews.apache.org/r/63861/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63861: Windows: Updated networking doc.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63861/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 10:05 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Changes
-------
fixed typo
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description
-------
The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.
Diffs (updated)
-----
docs/networking.md bdd3a762435aae163fc659cc0000fea7da825983
Diff: https://reviews.apache.org/r/63861/diff/5/
Changes: https://reviews.apache.org/r/63861/diff/4-5/
Testing
-------
Thanks,
Akash Gupta