You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2017/03/23 09:15:50 UTC

Re: svn commit: r1787937 - /ofbiz/ofbiz-framework/trunk/applications/content/src/main/java/org/apache/ ofbiz/content/content/ContentEvents.java

Le 23/03/2017 � 09:03, Jacopo Cappellato a �crit :
> Forwarding an email that I sent yesterday and seems to be lost in the net.
>
> Jacopo
>
> On Tue, Mar 21, 2017 at 1:34 PM, Jacopo Cappellato <
> jacopo.cappellato@hotwaxsystems.com> wrote:
>
>> On Tue, Mar 21, 2017 at 12:01 PM, <jl...@apache.org> wrote:
>>
>>> Log:
>>> No functional change, just a TODO for later
>>> [...]
>>>
>>> +        // TODO refactor I don't like much how this is written but it's
>>> not simple to refactor
>>>           boolean beganTx = false;
>>>
>> Thess changes should not be committed: they cause noise to a large
>> audience, add irrelevant comments to the code and make it look like it is a
>> personal repository.
>>
>> Please revert and find a better way, using your local repo, to keep track
>> of your work in progress.
>>
>> Jacopo
>>
I can remove this TODO, no problem

Jacques