You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <e....@gmx.net> on 2004/01/04 13:56:58 UTC
Resolving issue 1524: cvs2svn should replace "/" with "," ...
I attached a patch to issue 1524 (cvs2svn should replace "/" with "," or
something, in symbolic names) which not only replaces '/' with ',' but also
replaces '\' with ';'. Both characters ('/' and '\') are not forbidden
explicitly by cvs (v1.11) whereas ',' and ';' are, as can be concluded from the thread
attached to the issue.
Do you thinks this is an appropriate replacement rule?
bye,
Erik.
http://subversion.tigris.org/issues/show_bug.cgi?id=1524
--
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Resolving issue 1524: cvs2svn should replace "/" with "," ...
Posted by Max Bowsher <ma...@ukf.net>.
mark benedetto king wrote:
> On Sun, Jan 04, 2004 at 04:10:15PM +0100, Erik Huelsmann wrote:
>>> On Sun, Jan 04, 2004 at 02:56:58PM +0100, Erik Huelsmann wrote:
>>>>
>>>> I attached a patch to issue 1524 (cvs2svn should replace "/" with ","
or
>>>> something, in symbolic names) which not only replaces '/' with ',' but
also
>>>> replaces '\' with ';'. Both characters ('/' and '\') are not forbidden
>>>> explicitly by cvs (v1.11) whereas ',' and ';' are, as can be concluded
>>>> from the thread attached to the issue.
>>>>
>>>> Do you thinks this is an appropriate replacement rule?
>>>>
>>>
>>> IMO, ';' should be avoided in paths where possible, because of its
>>> significance to most unix shells. How about '.' or '@', instead?
>>
>> In which case it has to be @ since dots at the end of a filename don't
work
>> on windows. But the @ sign has meaning to Subversion for indicating a
>> revision number doesn't it? (That's why I elected not to use it.)
>>
>
> We could do something like:
>
> "/" -> ",slash,"
> "\" -> ",backslash,"
>
> But that's just too hideous; I'd rather the potential for bad ';'/shell
> interaction (which is technically "user error"). In that light, ";" is
> okay with me.
Furthermore, '\' already has bad shell interaction, so changing it to ';'
doesn't make the problem worse.
Re the patch: Looks good at first glance (I've never used Python string
transtbls though)
However, the run-tests.py portion has a couple of issues: The docstring
needs updating too, and the change to the test is incorrect. See one of the
other tests - e.g. resync_misgroups - for the correct idiom.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Resolving issue 1524: cvs2svn should replace "/" with "," ...
Posted by mark benedetto king <mb...@lowlatency.com>.
On Sun, Jan 04, 2004 at 04:10:15PM +0100, Erik Huelsmann wrote:
> > On Sun, Jan 04, 2004 at 02:56:58PM +0100, Erik Huelsmann wrote:
> > >
> > > I attached a patch to issue 1524 (cvs2svn should replace "/" with ","
> > or
> > > something, in symbolic names) which not only replaces '/' with ',' but
> > also
> > > replaces '\' with ';'. Both characters ('/' and '\') are not forbidden
> > > explicitly by cvs (v1.11) whereas ',' and ';' are, as can be concluded
> > from the thread
> > > attached to the issue.
> > >
> > > Do you thinks this is an appropriate replacement rule?
> > >
> >
> > IMO, ';' should be avoided in paths where possible, because of its
> > significance to most unix shells. How about '.' or '@', instead?
>
> In which case it has to be @ since dots at the end of a filename don't work
> on windows. But the @ sign has meaning to Subversion for indicating a
> revision number doesn't it? (That's why I elected not to use it.)
>
We could do something like:
"/" -> ",slash,"
"\" -> ",backslash,"
But that's just too hideous; I'd rather the potential for bad ';'/shell
interaction (which is technically "user error"). In that light, ";" is
okay with me.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Resolving issue 1524: cvs2svn should replace "/" with "," ...
Posted by Erik Huelsmann <e....@gmx.net>.
> On Sun, Jan 04, 2004 at 02:56:58PM +0100, Erik Huelsmann wrote:
> >
> > I attached a patch to issue 1524 (cvs2svn should replace "/" with ","
> or
> > something, in symbolic names) which not only replaces '/' with ',' but
> also
> > replaces '\' with ';'. Both characters ('/' and '\') are not forbidden
> > explicitly by cvs (v1.11) whereas ',' and ';' are, as can be concluded
> from the thread
> > attached to the issue.
> >
> > Do you thinks this is an appropriate replacement rule?
> >
>
> IMO, ';' should be avoided in paths where possible, because of its
> significance to most unix shells. How about '.' or '@', instead?
In which case it has to be @ since dots at the end of a filename don't work
on windows. But the @ sign has meaning to Subversion for indicating a
revision number doesn't it? (That's why I elected not to use it.)
bye,
Erik.
--
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Resolving issue 1524: cvs2svn should replace "/" with "," ...
Posted by mark benedetto king <mb...@lowlatency.com>.
On Sun, Jan 04, 2004 at 02:56:58PM +0100, Erik Huelsmann wrote:
>
> I attached a patch to issue 1524 (cvs2svn should replace "/" with "," or
> something, in symbolic names) which not only replaces '/' with ',' but also
> replaces '\' with ';'. Both characters ('/' and '\') are not forbidden
> explicitly by cvs (v1.11) whereas ',' and ';' are, as can be concluded from the thread
> attached to the issue.
>
> Do you thinks this is an appropriate replacement rule?
>
IMO, ';' should be avoided in paths where possible, because of its
significance to most unix shells. How about '.' or '@', instead?
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org