[jira] [Commented] (CLOUDSTACK-7355) [automation] test_netscaler_configs.py uses hardcoded NetScaler credentials

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212149#comment-14212149 ] 

ASF subversion and git services commented on CLOUDSTACK-7355:
-------------------------------------------------------------

Commit 3609f604473a5b61aec016786ba2dd671e2bd56e in cloudstack's branch refs/heads/4.5 from [~dougcl]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3609f60 ]

CLOUDSTACK-7355 - test_netscaler_configs.py uses hardcoded NetScaler credentials

Refactored code to use test_data instead of hardcoded NetScaler credentials
Refactored code to remove large scale duplication
Fixed some minor logic error in the existing tests

This patch has not added or removed any of the original test-cases.

Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>


> [automation] test_netscaler_configs.py uses hardcoded NetScaler credentials
> ---------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7355
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7355
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: marvin
>    Affects Versions: Future, 4.5.0
>            Reporter: Doug Clark
>            Assignee: Doug Clark
>             Fix For: 4.5.0
>
>
> test_netscaler_configs.py uses hardcoded NetScaler credentials.  This makes it impossible to execute this code without first editing it.
> Suggest adding the NetScaler credentials to Marvin test_data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)