You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/10 11:37:38 UTC
[GitHub] [pulsar] horizonzy opened a new pull request, #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
horizonzy opened a new pull request, #15104:
URL: https://github.com/apache/pulsar/pull/15104
Fixes #15103
### Motivation
Remove useless code.
- [ ] `no-need-doc`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1094252081
@horizonzy:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15104:
URL: https://github.com/apache/pulsar/pull/15104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1094252049
@horizonzy:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1140121569
This PR need to cherry-pick to another branch, because when invoke `cursor.ledger.startReadOperationOnLedger(nextReadPosition, OpReadEntry.this);` twice may cause NPE when ledger id equals `null` and then failed this `OpAddEntry` and recycle it.
@codelipenghui @horizonzy Could you help to confirm it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1094507622
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] horizonzy commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1140121808
Sure
发自我的iPhone
------------------ Original ------------------
From: Qiang Zhao ***@***.***>
Date: Sat,May 28,2022 8:46 AM
To: apache/pulsar ***@***.***>
Cc: Yan Zhao ***@***.***>, Mention ***@***.***>
Subject: Re: [apache/pulsar] [cleanup] [broker] Remove useless code to avoidconfusion in OpReadEntry#checkReadCompletion (PR #15104)
This PR need to cherry-pick to another branch, because when invoke cursor.ledger.startReadOperationOnLedger(nextReadPosition, OpReadEntry.this); twice may cause NPE when ledger id equals null and then failed this OpAddEntry and recycle it.
@codelipenghui @horizonzy Could you help to confirm it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org