You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/10/02 20:42:14 UTC
Re: Review Request 38577: Added synchronous validation for Call in
Agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 6:42 p.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
Bugs: MESOS-2906
https://issues.apache.org/jira/browse/MESOS-2906
Repository: mesos
Description
-------
Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
Diffs (updated)
-----
src/CMakeLists.txt 891f951
src/Makefile.am 8aa4566
src/slave/http.cpp f9cf7bb
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38577/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.hpp, line 31
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108614#file1108614line31>
> >
> > why space here?
Added it there after a review comment.
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.cpp, line 75
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75>
> >
> > also print status.source()
We don't have a stringify for this.
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/tests/executor_http_api_tests.cpp, line 505
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108616#file1108616line505>
> >
> > make sure this pattern is consistent everywhere else in this file.
Inversed advise here, killed this and made sure above pattern is consistent everywhere.
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------
On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 1:20 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-2906
> https://issues.apache.org/jira/browse/MESOS-2906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e6169a0
> src/Makefile.am e797dac
> src/slave/http.cpp 3f7f71b
> src/slave/validation.hpp PRE-CREATION
> src/slave/validation.cpp PRE-CREATION
> src/tests/executor_http_api_tests.cpp e429d84
>
> Diff: https://reviews.apache.org/r/38577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.cpp, line 75
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75>
> >
> > also print status.source()
>
> Isabel Jimenez wrote:
> We don't have a stringify for this.
Why not implement the `ostream` operator preferrably in `type_utils.hpp` in a separate review and mark this one as dependent on it ? Otherwise, this error string is hardly of any use to the end-user. What do you think?
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------
On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 1:20 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-2906
> https://issues.apache.org/jira/browse/MESOS-2906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e6169a0
> src/Makefile.am e797dac
> src/slave/http.cpp 3f7f71b
> src/slave/validation.hpp PRE-CREATION
> src/slave/validation.cpp PRE-CREATION
> src/tests/executor_http_api_tests.cpp e429d84
>
> Diff: https://reviews.apache.org/r/38577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Vinod Kone <vi...@gmail.com>.
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.cpp, line 75
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75>
> >
> > also print status.source()
>
> Isabel Jimenez wrote:
> We don't have a stringify for this.
>
> Anand Mazumdar wrote:
> Why not implement the `ostream` operator preferrably in `type_utils.hpp` in a separate review and mark this one as dependent on it ? Otherwise, this error string is hardly of any use to the end-user. What do you think?
+1 to anand's comment. but lets do that in a follow up review. i'll commit this chain now.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------
On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 1:20 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-2906
> https://issues.apache.org/jira/browse/MESOS-2906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e6169a0
> src/Makefile.am e797dac
> src/slave/http.cpp 3f7f71b
> src/slave/validation.hpp PRE-CREATION
> src/slave/validation.cpp PRE-CREATION
> src/tests/executor_http_api_tests.cpp e429d84
>
> Diff: https://reviews.apache.org/r/38577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------
Ship it!
src/slave/validation.hpp (line 19)
<https://reviews.apache.org/r/38577/#comment162368>
__SLAVE_VALIDATION_HPP__
src/slave/validation.hpp (line 31)
<https://reviews.apache.org/r/38577/#comment162369>
why space here?
src/slave/validation.cpp (line 25)
<https://reviews.apache.org/r/38577/#comment162370>
kill new line.
src/slave/validation.cpp (line 65)
<https://reviews.apache.org/r/38577/#comment162371>
space before 'does'
src/slave/validation.cpp (line 75)
<https://reviews.apache.org/r/38577/#comment162372>
also print status.source()
src/tests/executor_http_api_tests.cpp (line 502)
<https://reviews.apache.org/r/38577/#comment162373>
kill this?
src/tests/executor_http_api_tests.cpp (line 504)
<https://reviews.apache.org/r/38577/#comment162374>
make sure this pattern is consistent everywhere else in this file.
- Vinod Kone
On Oct. 27, 2015, 12:23 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 12:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-2906
> https://issues.apache.org/jira/browse/MESOS-2906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e6169a0
> src/Makefile.am e797dac
> src/slave/http.cpp 3f7f71b
> src/slave/validation.hpp PRE-CREATION
> src/slave/validation.cpp PRE-CREATION
> src/tests/executor_http_api_tests.cpp e429d84
>
> Diff: https://reviews.apache.org/r/38577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 1:20 a.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
Changes
-------
review
Bugs: MESOS-2906
https://issues.apache.org/jira/browse/MESOS-2906
Repository: mesos
Description
-------
Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
Diffs (updated)
-----
src/CMakeLists.txt e6169a0
src/Makefile.am e797dac
src/slave/http.cpp 3f7f71b
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
src/tests/executor_http_api_tests.cpp e429d84
Diff: https://reviews.apache.org/r/38577/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 12:23 a.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
Changes
-------
rebase
Bugs: MESOS-2906
https://issues.apache.org/jira/browse/MESOS-2906
Repository: mesos
Description
-------
Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
Diffs (updated)
-----
src/CMakeLists.txt e6169a0
src/Makefile.am e797dac
src/slave/http.cpp 3f7f71b
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
src/tests/executor_http_api_tests.cpp e429d84
Diff: https://reviews.apache.org/r/38577/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 38577: Added synchronous validation for Call in
Agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 3:54 p.m.)
Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
Bugs: MESOS-2906
https://issues.apache.org/jira/browse/MESOS-2906
Repository: mesos
Description
-------
Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
Diffs (updated)
-----
src/CMakeLists.txt 891f951
src/Makefile.am f060998
src/slave/http.cpp f9cf7bb
src/slave/validation.hpp PRE-CREATION
src/slave/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38577/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez