You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesatee.apache.org by GitBox <gi...@apache.org> on 2019/12/02 20:47:04 UTC

[GitHub] [incubator-mesatee] mssun commented on a change in pull request #112: rewrite kms with prost

mssun commented on a change in pull request #112: rewrite kms with prost
URL: https://github.com/apache/incubator-mesatee/pull/112#discussion_r352820135
 
 

 ##########
 File path: mesatee_services/tdfs/sgx_trusted_lib/src/tdfs_external.rs
 ##########
 @@ -135,8 +145,13 @@ impl HandleRequest for DeleteFileRequest {
 
         let target = config::Internal::target_kms();
         let mut client = KMSClient::new(target)?;
-        let key_resp = client.request_del_key(&file_meta.key_id)?;
-        let key_config = key_resp.config;
+        let key_req = kms_proto::proto::DeleteKeyRequest::new(&file_meta.key_id);
+        let key_resp = client.del_key(key_req)?;
+        let key_config = key_resp.get_key_config()?;
+        let key_config = match key_config {
+            kms_proto::KeyConfig::Aead(config) => kms_proto::proto::AeadConfig::from(config),
+            kms_proto::KeyConfig::ProtectedFs(_config) => unimplemented!(), // ProtectedFS is not used by TDFS yet. Config of ProtectedFs will not be generated neither.
 
 Review comment:
   No...I don't think this should be an error. Since this is just a placeholder and will be implemented anyway, otherwise the tdfs is not complete.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mesatee.apache.org
For additional commands, e-mail: dev-help@mesatee.apache.org