Re: [PR] [AMQ-9593] Add option to clean scheduled messages on startup [activemq]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre commented on code in PR #1352:
URL: https://github.com/apache/activemq/pull/1352#discussion_r2386755518


##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -184,6 +184,7 @@ public class BrokerService implements Service {
     private JmsConnector[] jmsBridgeConnectors; // these are Jms to Jms bridges
     // to other jms messaging systems
     private boolean deleteAllMessagesOnStartup;
+    private boolean deleteAllScheduledMessagesOnStartup = false;

Review Comment:
   I'm still in favor on a dedicated flag here, because the semantic is different so the behavior is.
   To reduce the "side effect" for existing users on ActiveMQ 6.x, I'm in favor of `deleteAllScheduledMessagesOnStartup`. We can revisit this for 7.x.
   
   @mattrpav @kenliao94 thoughts ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact