You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 04:38:05 UTC
[GitHub] [airflow] dstandish opened a new pull request, #22848: Disable foreign keys on sqlite when modifying dag_run
dstandish opened a new pull request, #22848:
URL: https://github.com/apache/airflow/pull/22848
If we do not disable FKs then it has the side effect of deleting all task instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22848:
URL: https://github.com/apache/airflow/pull/22848#discussion_r845732463
##########
airflow/migrations/utils.py:
##########
@@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name):
for constraint, constraint_type, col_name in result:
constraint_dict[constraint_type][constraint].append(col_name)
return constraint_dict
+
+
+from contextlib import contextmanager
Review Comment:
Why isn't this at the top of the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #22848:
URL: https://github.com/apache/airflow/pull/22848#discussion_r845742545
##########
airflow/migrations/utils.py:
##########
@@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name):
for constraint, constraint_type, col_name in result:
constraint_dict[constraint_type][constraint].append(col_name)
return constraint_dict
+
+
+from contextlib import contextmanager
Review Comment:
yeah sorry just oversight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22848:
URL: https://github.com/apache/airflow/pull/22848#discussion_r845732615
##########
airflow/migrations/utils.py:
##########
@@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name):
for constraint, constraint_type, col_name in result:
constraint_dict[constraint_type][constraint].append(col_name)
return constraint_dict
+
+
+from contextlib import contextmanager
Review Comment:
Ugh, too slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22848: Disable foreign keys on sqlite when modifying dag_run
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22848:
URL: https://github.com/apache/airflow/pull/22848#issuecomment-1092482704
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #22848: Disable foreign keys on sqlite when modifying dag_run
Posted by GitBox <gi...@apache.org>.
ashb merged PR #22848:
URL: https://github.com/apache/airflow/pull/22848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org