[jira] [Commented] (REEF-2024) Prepare existing artifacts for new module that introduces the new bridge

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498075#comment-16498075 ] 

ASF GitHub Bot commented on REEF-2024:
--------------------------------------

singlis commented on a change in pull request #1467: [REEF-2024] Prepare existing artifacts for new bridge module.
URL: https://github.com/apache/reef/pull/1467#discussion_r192417859
 
 

 ##########
 File path: lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilderFactory.java
 ##########
 @@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.reef.runtime.common.driver.evaluator;
+
+import org.apache.reef.driver.evaluator.EvaluatorDescriptor;
+import org.apache.reef.tang.annotations.DefaultImplementation;
+
+/**
+ * Evaluator descriptor builder factory interface.
+ */
+@DefaultImplementation(EvaluatorDescriptorImpl.EvaluatorDescriptorBuilderFactoryImpl.class)
+public interface EvaluatorDescriptorBuilderFactory {
 
 Review comment:
   Hi tcondie - does the naming of this follow another existing pattern? I would think this would be called IEvaluatorDescriptorBuilderFactory. Also does the builder need to be interfaced? Does this allow an application to define their own builder?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prepare existing artifacts for new module that introduces the new bridge
> ------------------------------------------------------------------------
>
>                 Key: REEF-2024
>                 URL: https://issues.apache.org/jira/browse/REEF-2024
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF Bridge
>    Affects Versions: 0.17
>            Reporter: Tyson Condie
>            Assignee: Tyson Condie
>            Priority: Major
>             Fix For: 0.17
>
>
> This Jira represents the changes needed to the existing codebase before introducing the module containing the new bridge.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)