You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/15 14:27:50 UTC

[GitHub] [spark] MaxGekk opened a new pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

MaxGekk opened a new pull request #31197:
URL: https://github.com/apache/spark/pull/31197


   ### What changes were proposed in this pull request?
   Replace `toMap` by `map(identity)` while getting canonicalized representation of `CatalogTable`. `CatalogTable` became not serializable after https://github.com/apache/spark/pull/31112 due to usage of `filterKeys`. The workaround was taken from https://github.com/scala/bug/issues/7005.
   
   ### Why are the changes needed?
   This prevents the errors like:
   ```
   [info]   org.apache.spark.SparkException: Job aborted due to stage failure: Task not serializable: java.io.NotSerializableException: scala.collection.immutable.MapLike$$anon$1
   [info]   Cause: java.io.NotSerializableException: scala.collection.immutable.MapLike$$anon$1
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   Should not.
   
   ### How was this patch tested?
   By running the test suite affected by https://github.com/apache/spark/pull/31112:
   ```
   $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableDropPartitionSuite"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761214420


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134124/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761121234


   **[Test build #134124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134124/testReport)** for PR 31197 at commit [`d26ea30`](https://github.com/apache/spark/commit/d26ea306bdeb6e83b0e32211bf972e19fa865155).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761116127


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134107/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761187832


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38707/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761187832


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38707/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761905611


   I think we cannot drop 2.12 easily in Apache Spark 3.x line like Hadoop 2.7.x.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761761206


   I think it's a bug fixed in Scala 2.13. Once we switch it to 2.13 by default and drop 2.12, it will prevent permanently I guess.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31197:
URL: https://github.com/apache/spark/pull/31197


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761280056


   Thank you, @MaxGekk . Merged to master/3.1/3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761210192


   **[Test build #134124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134124/testReport)** for PR 31197 at commit [`d26ea30`](https://github.com/apache/spark/commit/d26ea306bdeb6e83b0e32211bf972e19fa865155).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761697808


   Also, cc @gatorsmile 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761697735


   Do you think if we can have a way for us to prevent this kind of regression, @cloud-fan , @HyukjinKwon , @MaxGekk ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761035977


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38691/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761116127


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134107/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761171039


   > According to the original patch, do we need this for master/3.1/3.0 ...
   
   @dongjoon-hyun Yes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761214420


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134124/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761761206


   I think it's a bug fixed in Scala 2.13. Once we upgrade, it will prevent permanently I guess.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761121234


   **[Test build #134124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134124/testReport)** for PR 31197 at commit [`d26ea30`](https://github.com/apache/spark/commit/d26ea306bdeb6e83b0e32211bf972e19fa865155).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761180569


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38707/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761017030


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38691/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-760988325


   **[Test build #134107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134107/testReport)** for PR 31197 at commit [`81d6786`](https://github.com/apache/spark/commit/81d678653dad6525b68c58206480692caa51f4d3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761163866


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38707/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761051358


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38691/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31197: [SPARK-34060][SQL][FOLLOWUP] Preserve serializability of canonicalized CatalogTable

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31197:
URL: https://github.com/apache/spark/pull/31197#issuecomment-761051358


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38691/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org