You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Дмитрий Рябов <so...@gmail.com> on 2017/03/20 13:01:46 UTC

Ignite-4795 - ready for review

Hello, community. Please, review and/or suggest something about javadocs of
transactions.

PR: https://github.com/apache/ignite/pull/1630/files

JIRA: https://issues.apache.org/jira/browse/IGNITE-4795

Re: Ignite-4795 - ready for review

Posted by Дмитрий Рябов <so...@gmail.com>.

Andrey, I made fix, can you look it again?

2017-03-28 20:40 GMT+03:00 Andrey Gura <ag...@apache.org>:

> Dmitry, see JIRA ticket for review comments.
>
> On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda <dm...@apache.org> wrote:
> > Hello Dmitriy, thanks! Someone will have a look at your changes soon.
> Sorry for the delay.
> >
> > —
> > Denis
> >
> >> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <so...@gmail.com>
> wrote:
> >>
> >> Hello, can anyone review this issue?
> >>
> >> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
> >>
> >>> Done.
> >>>
> >>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <ch...@gmail.com>:
> >>>
> >>>> Dmitry, thank you!
> >>>>
> >>>> Could you please also change issue status to "Patch available".
> >>>>
> >>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
> >>>>
> >>>>> Hello, community. Please, review and/or suggest something about
> >>>> javadocs of
> >>>>> transactions.
> >>>>>
> >>>>> PR: https://github.com/apache/ignite/pull/1630/files
> >>>>>
> >>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> С уважением,
> >>>> Чураев Антон
> >>>>
> >>>
> >>>
> >
>

Re: Ignite-4795 - ready for review

Posted by Andrey Gura <ag...@apache.org>.

Dmitry, see JIRA ticket for review comments.

On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda <dm...@apache.org> wrote:
> Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry for the delay.
>
> —
> Denis
>
>> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <so...@gmail.com> wrote:
>>
>> Hello, can anyone review this issue?
>>
>> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
>>
>>> Done.
>>>
>>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <ch...@gmail.com>:
>>>
>>>> Dmitry, thank you!
>>>>
>>>> Could you please also change issue status to "Patch available".
>>>>
>>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
>>>>
>>>>> Hello, community. Please, review and/or suggest something about
>>>> javadocs of
>>>>> transactions.
>>>>>
>>>>> PR: https://github.com/apache/ignite/pull/1630/files
>>>>>
>>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> С уважением,
>>>> Чураев Антон
>>>>
>>>
>>>
>

Re: Ignite-4795 - ready for review

Posted by Denis Magda <dm...@apache.org>.

Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry for the delay.

—
Denis

> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов <so...@gmail.com> wrote:
> 
> Hello, can anyone review this issue?
> 
> 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
> 
>> Done.
>> 
>> 2017-03-20 16:30 GMT+03:00 Антон Чураев <ch...@gmail.com>:
>> 
>>> Dmitry, thank you!
>>> 
>>> Could you please also change issue status to "Patch available".
>>> 
>>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
>>> 
>>>> Hello, community. Please, review and/or suggest something about
>>> javadocs of
>>>> transactions.
>>>> 
>>>> PR: https://github.com/apache/ignite/pull/1630/files
>>>> 
>>>> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> С уважением,
>>> Чураев Антон
>>> 
>> 
>>

Re: Ignite-4795 - ready for review

Posted by Дмитрий Рябов <so...@gmail.com>.

Hello, can anyone review this issue?

2017-03-20 16:33 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:

> Done.
>
> 2017-03-20 16:30 GMT+03:00 Антон Чураев <ch...@gmail.com>:
>
>> Dmitry, thank you!
>>
>> Could you please also change issue status to "Patch available".
>>
>> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
>>
>> > Hello, community. Please, review and/or suggest something about
>> javadocs of
>> > transactions.
>> >
>> > PR: https://github.com/apache/ignite/pull/1630/files
>> >
>> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>> >
>>
>>
>>
>> --
>> С уважением,
>> Чураев Антон
>>
>
>

Re: Ignite-4795 - ready for review

Posted by Дмитрий Рябов <so...@gmail.com>.

Done.

2017-03-20 16:30 GMT+03:00 Антон Чураев <ch...@gmail.com>:

> Dmitry, thank you!
>
> Could you please also change issue status to "Patch available".
>
> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:
>
> > Hello, community. Please, review and/or suggest something about javadocs
> of
> > transactions.
> >
> > PR: https://github.com/apache/ignite/pull/1630/files
> >
> > JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
> >
>
>
>
> --
> С уважением,
> Чураев Антон
>

Re: Ignite-4795 - ready for review

Posted by Антон Чураев <ch...@gmail.com>.

Dmitry, thank you!

Could you please also change issue status to "Patch available".

2017-03-20 16:01 GMT+03:00 Дмитрий Рябов <so...@gmail.com>:

> Hello, community. Please, review and/or suggest something about javadocs of
> transactions.
>
> PR: https://github.com/apache/ignite/pull/1630/files
>
> JIRA: https://issues.apache.org/jira/browse/IGNITE-4795
>



-- 
С уважением,
Чураев Антон