You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by vraghavan78 <gi...@git.apache.org> on 2016/04/26 20:19:00 UTC
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
GitHub user vraghavan78 opened a pull request:
https://github.com/apache/incubator-hawq/pull/630
Fix Orca error message: Orca supports Rollup #117665973
Fixing the error message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vraghavan78/incubator-hawq error-msg-117665973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #630
----
commit f78d6f541748b81a6d3526efef84c6d4ca3865ed
Author: Venkatesh (Venky) Raghavan <vr...@pivotal.io>
Date: 2016-04-26T18:18:08Z
Fix Orca error message: Orca supports Rollup #117665973
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/630#issuecomment-215043125
@vraghavan78 , merged, please close this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/630#discussion_r61138397
--- Diff: src/backend/gpopt/translate/CTranslatorUtils.cpp ---
@@ -1583,9 +1585,9 @@ CTranslatorUtils::PdrgpbsGroupBy
return PdrgpbsRollup(pmp, pgrcl, ulCols, phmululGrpColPos, pbsGrpCols);
}
- if (GROUPINGTYPE_GROUPING_SETS != pgrcl->groupType)
+ if (GROUPINGTYPE_CUBE == pgrcl->groupType)
{
- GPOS_RAISE(gpdxl::ExmaDXL, gpdxl::ExmiQuery2DXLUnsupportedFeature, GPOS_WSZ_LIT("Rollup and cube"));
+ GPOS_RAISE(gpdxl::ExmaDXL, gpdxl::ExmiQuery2DXLUnsupportedFeature, GPOS_WSZ_LIT(“Cube”));
--- End diff --
the quote marks look off. should be `"` and not `“`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/630#issuecomment-214851839
Thanks @hornn
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix Orca error message: Orca supports...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/630#issuecomment-214923374
@vraghavan78 GA build was cut yesterday. so this can only be after 2.0. the master branch will be open for commit today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---