You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/11/10 10:03:10 UTC
[GitHub] cloudstack pull request #1758: CLOUDSTACK-9588: Add Load Balancer functional...
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1758
CLOUDSTACK-9588: Add Load Balancer functionality in Network page is Redundant.
Steps to Reproduce:
Network -> Select any network -> Observer Add Load Balancer tab
The "Add Load Balancer" functionality is redundant.
The above is used to create LB rule without any public IP.
Resolution:
There exist similar functionality in Network -> Any Network -> Details Tab -> View IP Addresses -> Any public IP -> Configuration Tab -> Observe Load Balancing.
The above is used to create LB rule with a public IP. This is a more convenient way of creating LB rule as the IP is involved.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/CloudStack-Nitin CloudStack-Nitin-4.9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1758
----
commit 49844e626bdf5788508186b7f037c46442e3a5b4
Author: Nitin Kumar Maharana <ni...@accelerite.com>
Date: 2016-11-10T09:57:52Z
CLOUDSTACK-9588: Add Load Balancer functionality in Network page is redundant.
The "Add Load Balancer" functionality is redundant.
The above is used to create LB rule without any public IP.
This commit removes the tab from network page.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1758
I think this UI change was made when VxLan implementation is done from community.
I saw in one of the demo videe of VxLan this page is used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
ping @rajesh-battala @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@rajesh-battala : From my observation, I found whatever we can do in Add Load Balancer tab, the same can be performed in load balancing section after selecting any IP. Do you think any scenario where we cannot add rules by using the later one but can be done in Add load balancer tab? Can you please give the pointer to that video. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@rajesh-battala : Thanks for giving the details. I will go through the video. If i find a case where it is really required then I will modify the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
The Add Load Balancer tab was removed.
The same functionality is done by Load Balancing tab.
<img width="1182" alt="screen shot 2016-11-15 at 10 32 33 am" src="https://cloud.githubusercontent.com/assets/12583725/20293902/26cd3f1e-ab20-11e6-9b59-05ac6ec8194b.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@rajesh-battala : I went through the video but couldn't observe working on the add load balancer part. He touched the egress rules part. BTW, the tab was added in this commit https://github.com/apache/cloudstack/commit/196e36d194274067d16ee7dec037e2dd5721b839. I looked at the code change as well, which is very similar to what we do in case of load balancing section with an IP address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1758
Packaging result: \u2716centos6 \u2714centos7 \u2714debian. JID-173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1758: CLOUDSTACK-9588: Add Load Balancer functional...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@nitin-maharana could you please provide a screenshot of this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@nitin-maharana LGTM for code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@sateesh-chodapuneedi @karuturi : Can you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@karuturi This is ready for merge. UI change only, 2 LGTMs, UI screenshot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1758
ok. if you find that page is not used then please feel free to remove it.
Having that page will confuse the Admin for create Firewall rules
On Wed, Dec 7, 2016 at 3:39 PM, Nitin Kumar Maharana <
notifications@github.com> wrote:
> @rajesh-battala <https://github.com/rajesh-battala> : I went through the
> video but couldn't observe working on the add load balancer part. He
> touched the egress rules part. BTW, the tab was added in this commit
> 196e36d
> <https://github.com/apache/cloudstack/commit/196e36d194274067d16ee7dec037e2dd5721b839>.
> I looked at the code change as well, which is very similar to what we do in
> case of load balancing section with an IP address.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cloudstack/pull/1758#issuecomment-265407462>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA-EAjWK1ArcMyt6gwP6jj1_m26tgghzks5rFoXmgaJpZM4KuekP>
> .
>
--
Thanks
Rajesh Battala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1758
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...
Posted by rajesh-battala <gi...@git.apache.org>.
Github user rajesh-battala commented on the issue:
https://github.com/apache/cloudstack/pull/1758
Here is the link https://www.youtube.com/watch?v=qybCr1klhKk&t=1108s
I have seen in this demo video about using that extra page
On Tue, Dec 6, 2016 at 4:33 PM, Nitin Kumar Maharana <
notifications@github.com> wrote:
> @rajesh-battala <https://github.com/rajesh-battala> : From my
> observation, I found whatever we can do in Add Load Balancer tab, the same
> can be performed in load balancing section after selecting any IP. Do you
> think any scenario where we cannot add rules by using the later one but can
> be done in Add load balancer tab? Can you please give the pointer to that
> video. Thanks.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cloudstack/pull/1758#issuecomment-265122222>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA-EAnTIwbGB8vXbZLqFSgFmQ_eYJ0B1ks5rFUD-gaJpZM4KuekP>
> .
>
--
Thanks
Rajesh Battala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---