[GitHub] [beam] ibzib commented on a change in pull request #10708: [BEAM-9213] throw error when flink_submit_uber_jar and not flink_master

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #10708: [BEAM-9213] throw error when flink_submit_uber_jar and not flink_master
URL: https://github.com/apache/beam/pull/10708#discussion_r392370237
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/flink_runner.py
 ##########
 @@ -51,8 +51,11 @@ def default_job_server(self, options):
     flink_master = self.add_http_scheme(
         flink_options.flink_master)
     flink_options.flink_master = flink_master
-    if (flink_options.flink_submit_uber_jar
-        and flink_master not in MAGIC_HOST_NAMES):
+    if flink_options.flink_submit_uber_jar:
+      if flink_master in MAGIC_HOST_NAMES:
+        raise ValueError(
+            'Cannot use flink_submit_uber_jar with flink_master %s'
+            % flink_master)
 
 Review comment:
   Circling back on this now that BEAM-9225 is resolved.
   
   > (1) If no options are provided, a local flink cluster is started up and is used,
   > (2) If a master is specified, we submit it to that job in the least intrusive way possible (IMHO, the so-called uberjar method, though I'm curious about BEAM-9225).
   
   This makes sense to me. I'm leaning toward removing `flink_submit_uber_jar` and replacing the condition with `flink_master`.
   
   > How about a --force-mode parameter which would enforce a specific mode, e.g. --force-mode uberjar to user the uber jar mode.
   
   I prefer removing parameters where possible. Ideally we can come up with a solution here that works without the user having to know all about the different implementations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services