You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2023/08/02 19:33:38 UTC
[GitHub] [cloudstack] jbampton opened a new pull request, #7805: pre-commit: add hook to check for the existence of private keys
jbampton opened a new pull request, #7805:
URL: https://github.com/apache/cloudstack/pull/7805
https://github.com/pre-commit/pre-commit-hooks#detect-private-key
The "exclude" list is the list of "keys" currently found by this hook
### Description
This PR adds another pre-commit hook or "test" to check for "keys" in the codebase
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
You can test locally with pre-commit from the repo root:
`pre-commit run --all-files`
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1662932440
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7805](https://app.codecov.io/gh/apache/cloudstack/pull/7805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e1c115a) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/6f4503488be95d30727af9c69170fc9bac13ec1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6f45034) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7805 +/- ##
============================================
- Coverage 13.44% 13.44% -0.01%
+ Complexity 9400 9396 -4
============================================
Files 2747 2747
Lines 258844 258844
Branches 40313 40313
============================================
- Hits 34804 34790 -14
- Misses 219655 219674 +19
+ Partials 4385 4380 -5
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7805/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663409082
> > looks good, not sure if the console proxy should be excluded though
>
> Hey @DaanHoogland when you run this new hook for the first time it finds that list of keys in the codebase.
>
> So I was then excluding them assuming they were all valid keys that we need.
yeah, makes sense and I have no doubts about most (systemvm and tests) . I'll need to look at the consoleproxy one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663404741
> looks good, not sure if the console proxy should be excluded though
Hey @DaanHoogland when you run this new hook for the first time it finds that list of keys in the codebase.
So I was then excluding them assuming they were all valid keys that we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663396817
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663333997
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663335762
@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7805: pre-commit: add hook to check for the existence of private keys
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7805:
URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663914910
> > > looks good, not sure if the console proxy should be excluded though
> >
> >
> > Hey @DaanHoogland when you run this new hook for the first time it finds that list of keys in the codebase.
> > So I was then excluding them assuming they were all valid keys that we need.
>
> yeah, makes sense and I have no doubts about most (systemvm and tests) . I'll need to look at the consoleproxy one.
false alarm (didn't notice this is in a test dir as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org