You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brahma Reddy Battula (JIRA)" <ji...@apache.org> on 2012/05/25 04:22:16 UTC

[jira] [Created] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Brahma Reddy Battula created HADOOP-8433:
--------------------------------------------

             Summary: Logs are getting misplaced after introducing hadoop-env.sh
                 Key: HADOOP-8433
                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
             Project: Hadoop Common
          Issue Type: Bug
          Components: scripts
    Affects Versions: 2.0.1-alpha, 3.0.0
            Reporter: Brahma Reddy Battula


It's better to comment the following in hadoop-env.sh

# Where log files are stored.  $HADOOP_HOME/logs by default.
export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER

Because of this logs are placing under root($user) and this getting called two times while starting process.
hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283136#comment-13283136 ] 

Brahma Reddy Battula commented on HADOOP-8433:
----------------------------------------------

Hi Eli,

thanks for look.

Yes.. Logs are placed /root/root/


 
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins reassigned HADOOP-8433:
-----------------------------------

    Assignee: Brahma Reddy Battula

Hi Brahma,

You're seeing /root/root from a tarball install?  How did you test this change?

Thanks,
ELi
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294176#comment-13294176 ] 

Hudson commented on HADOOP-8433:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2357 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2357/])
    HADOOP-8433. Don't set HADOOP_LOG_DIR in hadoop-env.sh. Contributed by Brahma Reddy Battula (Revision 1349641)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349641
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh

                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brahma Reddy Battula updated HADOOP-8433:
-----------------------------------------

    Attachment: Hadoop-8433.patch

Attaching patch by commeting HADOOP_LOG_DIR in haddop-env.sh.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brahma Reddy Battula updated HADOOP-8433:
-----------------------------------------

    Status: Patch Available  (was: Open)

Attached patch
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283137#comment-13283137 ] 

Eli Collins commented on HADOOP-8433:
-------------------------------------

Thanks Brahma, this is building the tarballs using user root or using the packages?

There are two copies of hadoop-env.sh, let's update both to be consistent.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289352#comment-13289352 ] 

Brahma Reddy Battula commented on HADOOP-8433:
----------------------------------------------

HI Jay Finger,

Thanks For look..

fyi ..I had proposed following two solutions when I raised..
{quote}
Solution can be removing $user or commenting HADOOP_LOG_DIR in hadoop-env.sh..
{quote}
I am agreeing with you..

{quote}
I don't like the approach of commenting this line out. I think a lot of admins will infer from this that uncommenting the line will result in some useful behavior
{quote}

It wn't harm by commenting this property since it'll be set in hadoop-daemon.sh...I think it's better to remove $USER..Please let me know..

{quote}
A bigger problem is that hadoop-env.sh is sometimes included twice
{quote}

Anyway this will be addressed by HADOOP-8464.

                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294482#comment-13294482 ] 

Hudson commented on HADOOP-8433:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1108 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1108/])
    HADOOP-8433. Don't set HADOOP_LOG_DIR in hadoop-env.sh. Contributed by Brahma Reddy Battula (Revision 1349641)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349641
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh

                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282986#comment-13282986 ] 

Brahma Reddy Battula commented on HADOOP-8433:
----------------------------------------------

Solution can be removing $user or commenting HADOOP_LOG_DIR in hadoop-env.sh..
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284388#comment-13284388 ] 

Hadoop QA commented on HADOOP-8433:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12529950/HADOOP-8433.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1041//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1041//console

This message is automatically generated.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294233#comment-13294233 ] 

Hudson commented on HADOOP-8433:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2377 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2377/])
    HADOOP-8433. Don't set HADOOP_LOG_DIR in hadoop-env.sh. Contributed by Brahma Reddy Battula (Revision 1349641)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349641
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh

                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8433:
--------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.1-alpha
    Target Version/s:   (was: 2.0.1-alpha)
              Status: Resolved  (was: Patch Available)

I've committed this and merged to branch-2. Thanks Brahma.
                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brahma Reddy Battula updated HADOOP-8433:
-----------------------------------------

    Attachment: HADOOP-8433.patch

HI Eli,

I have updated both places..thanks a lot
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8433.
---------------------------------

    
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.0-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.2-alpha
>
>         Attachments: Hadoop-8433.patch, HADOOP-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Brahma Reddy Battula (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283133#comment-13283133 ] 

Brahma Reddy Battula commented on HADOOP-8433:
----------------------------------------------


I have commented (In haddop-env.sh) since LOG_DIR will be set in hadoop-daemon.sh..Like following..

if [ ! -w "$HADOOP_LOG_DIR" ] ; then
  mkdir -p "$HADOOP_LOG_DIR"
  chown $HADOOP_IDENT_STRING $HADOOP_LOG_DIR
fi
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294186#comment-13294186 ] 

Hudson commented on HADOOP-8433:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2430 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2430/])
    HADOOP-8433. Don't set HADOOP_LOG_DIR in hadoop-env.sh. Contributed by Brahma Reddy Battula (Revision 1349641)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349641
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh

                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8433:
--------------------------------

     Target Version/s: 2.0.1-alpha  (was: 2.0.0-alpha, 3.0.0)
    Affects Version/s:     (was: 3.0.0)
              Summary: Don't set HADOOP_LOG_DIR in hadoop-env.sh  (was: Logs are getting misplaced after introducing hadoop-env.sh)
         Hadoop Flags: Reviewed

+1 latest patch looks good, I tested it against a tarball install.
                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283115#comment-13283115 ] 

Hadoop QA commented on HADOOP-8433:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12529565/Hadoop-8433.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1031//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1031//console

This message is automatically generated.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>         Attachments: Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Logs are getting misplaced after introducing hadoop-env.sh

Posted by "Jay Finger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287516#comment-13287516 ] 

Jay Finger commented on HADOOP-8433:
------------------------------------

I don't like the approach of commenting this line out.  I think a lot of admins will infer from this that uncommenting the line will result in some useful behavior.

A bigger problem is that hadoop-env.sh is sometimes included twice.  For example, hadoop-daemon.sh includes hadoop-config.sh, which includes hadoop-env.sh.  Then later hadoop-daemon.sh includes hadoop-env.sh explicitly.  It seems to me that this is the actual root cause of the issue, and that it is likely going to cause other headaches in the future by people who don't suspect that it will be included twice.
                
> Logs are getting misplaced after introducing hadoop-env.sh
> ----------------------------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha, 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8433) Don't set HADOOP_LOG_DIR in hadoop-env.sh

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294376#comment-13294376 ] 

Hudson commented on HADOOP-8433:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1075 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1075/])
    HADOOP-8433. Don't set HADOOP_LOG_DIR in hadoop-env.sh. Contributed by Brahma Reddy Battula (Revision 1349641)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1349641
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/packages/templates/conf/hadoop-env.sh

                
> Don't set HADOOP_LOG_DIR in hadoop-env.sh
> -----------------------------------------
>
>                 Key: HADOOP-8433
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8433
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8433.patch, Hadoop-8433.patch
>
>
> It's better to comment the following in hadoop-env.sh
> # Where log files are stored.  $HADOOP_HOME/logs by default.
> export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
> Because of this logs are placing under root($user) and this getting called two times while starting process.
> hence logs are placing at /root/root/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira