[jira] [Commented] (YARN-9629) Support configurable MIN_LOG_ROLLING_INTERVAL

["Szilard Nemeth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875976#comment-16875976 ] 

Szilard Nemeth commented on YARN-9629:
--------------------------------------

Hi [~adam.antal]!
Thanks for the update!

The code changes you made for patch004 regarding documentation in yarn-default.xml looks good to me.
One minor thing left: Could you please remove any "suggested" references (variable names, log messages) in method org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.LogAggregationService#calculateRollingMonitorInterval? 

Thanks!

> Support configurable MIN_LOG_ROLLING_INTERVAL
> ---------------------------------------------
>
>                 Key: YARN-9629
>                 URL: https://issues.apache.org/jira/browse/YARN-9629
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: log-aggregation, nodemanager, yarn
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Minor
>         Attachments: YARN-9629.001.patch, YARN-9629.002.patch, YARN-9629.003.patch, YARN-9629.004.patch
>
>
> One of the log-aggregation parameter, the minimum valid value for {{yarn.nodemanager.log-aggregation.roll-monitoring-interval-seconds}} is MIN_LOG_ROLLING_INTERVAL - it has been hardcoded since its addition in YARN-2583. 
> It has been empirically set as 1 hour, as lower values would too frequently put the NodeManagers under pressure. For bigger clusters that is indeed a valid limitation, but for smaller clusters it makes sense and a valid customer usecase to use lower values, even like not so lower 30 mins. At this point this can only be achieved by setting {{yarn.nodemanager.log-aggregation.debug-enabled}}, which I believe should be kept as debug purposes.
> I'm suggesting to make this min configurable, although a warning should be logged in the NodeManager startup when this value is lower than 1 hour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org