[GitHub] [apisix] spacewander commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r734408214



##########
File path: docs/zh/latest/grpc-proxy.md
##########
@@ -66,6 +66,8 @@ grpcurl -insecure -import-path /pathtoprotos  -proto helloworld.proto  \
 }
 ```
 
+> grpcurl 是一个 CLI 工具，类似于 curl，充当 gRPC 客户端并让您与 gRPC 服务器进行交互。安装请查看官方 [文件](https://github.com/fullstorydev/grpcurl#installation)

Review comment:
       ```suggestion
   > grpcurl 是一个 CLI 工具，类似于 curl，充当 gRPC 客户端并让您与 gRPC 服务器进行交互。安装方式请查看官方[文档](https://github.com/fullstorydev/grpcurl#installation)
   ```

##########
File path: .github/workflows/build.yml
##########
@@ -38,6 +38,11 @@ jobs:
         with:
           submodules: recursive
 
+      - name: Setup Go
+        uses: actions/setup-go@v2.1.4
+        with:
+          go-version: "^1.13"

Review comment:
       Better to specify a fix version

##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,9 @@ install_dependencies() {
     # wait for grpc_server_example to fully start
     sleep 3
 
+    # installing grpcurl
+    go install github.com/fullstorydev/grpcurl/cmd/grpcurl@latest

Review comment:
       Ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org