RE: NNTP : cannot download postings

["Noel J. Bergman" <no...@devtech.com>]

Harmeet,

I am *still* waiting to see these patches you keep talking about.  I have
patches that were submitted last year, and they were posted to the group for
review.  You asked me to postpone committing them, without indicating what
issue, if any, you have with them.  Where are yours, if they are different?

Why are you proposing to have the patches in the CVS by the weekend when you
haven't posted them for review?

	--- Noel

-----Original Message-----
From: Harmeet Bedi [mailto:harmeet@kodemuse.com]
Sent: Thursday, January 09, 2003 14:07
To: James Users List; martin@woolleynet.com
Subject: Re: NNTP : cannot download postings

----- Original Message -----
From: "Martin Woolley" <ma...@yahoo.com>

> Thanks Noel.
>
> Does "almost immediately" mean it will hit one of the nightly releases or
> milestone builds?

I will be in nightly builds latest by this this weekend. Would suggest you
check the 3.0 or  2.1 branch on Monday.
What news reader are you using ? I was hoping to test with at least a subset
of Outlook, Opera, Netscape 4.7, Mozilla and KNode.
Other interesting newsreaders for me are Gnus in Emacs and Pine.

Harmeet


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: NNTP : cannot download postings

[Harmeet Bedi <ha...@kodemuse.com>]

Noel, if you have the patches and feel I am blocking you, go ahead I can
work on top of the patches if there is any need to. Test it and checkin if
you can't wait.

Hope that sounds ok.
Harmeet


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: NNTP : cannot download postings

["Noel J. Bergman" <no...@devtech.com>]

> Thanks for the update Harmeet.  I agree it's good to get testing setup
> first before getting into fixing the NNTP server code.

I'm very much looking forward to Harmeet's tests.

> And like you said, Noel if you want to get something patched sooner
> rather than wait for Harmeet's work, go ahead.

Patches are posted for review, and I just posted a Nightly build to get user
feedback.

	--- Noel


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: NNTP : cannot download postings

[Serge Knystautas <se...@lokitech.com>]

Harmeet Bedi wrote:
> ----- Original Message -----
> From: "Noel J. Bergman" <no...@devtech.com>
> 
>>I am *still* waiting to see these patches you keep talking about.
> 
> 
> I have told that I want regression tests first and then patch.
 >
> [...]
> 
> If this is too much for you to accept and you want a more aggressive
> schedule please go ahead and do what makes sense.

Thanks for the update Harmeet.  I agree it's good to get testing setup 
first before getting into fixing the NNTP server code.

And like you said, Noel if you want to get something patched sooner 
rather than wait for Harmeet's work, go ahead.

-- 
Serge Knystautas
Loki Technologies
http://www.lokitech.com


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: NNTP : cannot download postings

["Noel J. Bergman" <no...@devtech.com>]

> I have told that I want regression tests first and then patch.

Fine.  Then if you don't have any patches to conflict with the ones that I
have, we might as well start with them.  At least I won't be stepping on any
code you haven't already written.  If you had written some there would be no
reason not to allow people to review thme so far.

> why can't you wait rather than badger away ?

I'm not badgering you.  You had previously said that you already had some
patches, but wanted to test first.  If what you really have so far are just
the tests, that's great.  Please run them against the new patches I've
submitted.  I am sure that there are yet more bugs to fix, since I've just
documented several.

> I am obviously unhappy that the quality of NNTP has degraded.

As far as I can see from the CVS, the defects that I just patched have been
there since before.  Regardless, I've checked them against the RFC, as can
you from the descriptions I've posted.

> How do you expect to have the collection of entire set of patches that
> address various clients without sufficient tests.

I don't.  But I know that what I just did corrects real verifiable defects,
and that I can now work with OE and Netscape news against my test server.
So there is no reason not to fix what we can easily see as being wrong,
while still waiting for the test suite that we agree is vital.

I appreciate your time constraints.  We all have them.  But what I've just
posted should not in any way negatively impact either the code or future
changes.  No restructuring.  Just some very simple in-line patches.

If no one objects to them specifically, I'd like to commit them tomorrow as
a starting point.

	--- Noel


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: NNTP : cannot download postings

[Harmeet Bedi <ha...@kodemuse.com>]

----- Original Message -----
From: "Noel J. Bergman" <no...@devtech.com>
> I am *still* waiting to see these patches you keep talking about.

I have told that I want regression tests first and then patch.
I have committed to the time frame of this weekend a few times, why can't
you wait rather than badger away ?

Most of the problems are not due to lack of ability to patch code, but due
to absense of repeatable tests. I am hoping to fix the problem rather than
patch. This would only help the patches you want to put in. I am obviously
unhappy that the quality of NNTP has degraded. Rather than rush to
patch(which I can easily do having written this module) I would like a
system in place so that this never happens again and everybody can more
easily contribute.

How do you expect to have the collection of entire set of patches that
address various clients without sufficient tests. I have personal reasons
why I can't get to this sooner than the weekend and even then I am doing
this work at significant personal hit only because I care about James.

If this is too much for you to accept and you want a more aggressive
schedule please go ahead and do what makes sense.

cheers,
Harmeet


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>