You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/08/03 19:16:47 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7190: Minor: refine memory_limit tests
alamb opened a new pull request, #7190:
URL: https://github.com/apache/arrow-datafusion/pull/7190
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/7130
## Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/5885
## Rationale for this change
As DataFusion's memory limiting gets more sophisticated so do the tests for these limits. I made them better in https://github.com/apache/arrow-datafusion/pull/7131 and https://github.com/apache/arrow-datafusion/pull/7130 but they could be more self describing
## What changes are included in this PR?
Complete switching memory_limit tests to builder style so each test reads more fluently and it is easier to understand what is going on
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #7190: Minor: make memory_limit tests more self describing
Posted by "yjshen (via GitHub)" <gi...@apache.org>.
yjshen merged PR #7190:
URL: https://github.com/apache/arrow-datafusion/pull/7190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7190: Minor: make memory_limit tests more self describing
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7190:
URL: https://github.com/apache/arrow-datafusion/pull/7190#discussion_r1298490469
##########
datafusion/core/tests/memory_limit.rs:
##########
@@ -55,118 +55,110 @@ fn init() {
#[tokio::test]
async fn oom_sort() {
- TestCase::new(
- "select * from t order by host DESC",
- vec![
+ TestCase::new()
+ .with_query("select * from t order by host DESC")
Review Comment:
the major change is that by using a builder pattern, now the tests are more explicit about what the values are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #7190: Minor: make memory_limit tests more self describing
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7190:
URL: https://github.com/apache/arrow-datafusion/pull/7190#issuecomment-1684169431
Thank you for the review @metesynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org