You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whimsical.apache.org by Sam Ruby <ru...@intertwingly.net> on 2016/05/19 23:55:16 UTC

Re: [whimsy] branch master updated: Also ignore code_version changes if that's all that's changed

On Thu, May 19, 2016 at 7:52 PM,  <se...@apache.org> wrote:
>
>  # Massage the strings to drop the timestamps so spurious changes are not reported/saved
>  def removeTimestamps(s)
> -  return s.sub(/  "last_updated": "[^"]+",/, '')
> +  return s.sub(/  "last_updated|code_version": "[^"]+",/, '')
>  end

Should this be gsub?

See:

https://whimsy.apache.org/public/member-info.json

- Sam Ruby

Re: [whimsy] branch master updated: Also ignore code_version changes if that's all that's changed

Posted by sebb <se...@gmail.com>.

On 20 May 2016 at 00:55, Sam Ruby <ru...@intertwingly.net> wrote:
> On Thu, May 19, 2016 at 7:52 PM,  <se...@apache.org> wrote:
>>
>>  # Massage the strings to drop the timestamps so spurious changes are not reported/saved
>>  def removeTimestamps(s)
>> -  return s.sub(/  "last_updated": "[^"]+",/, '')
>> +  return s.sub(/  "last_updated|code_version": "[^"]+",/, '')
>>  end
>
> Should this be gsub?

Good catch.

> See:
>
> https://whimsy.apache.org/public/member-info.json
>
> - Sam Ruby