[GitHub] [calcite] danny0405 commented on a change in pull request #2062: [CALCITE-4094] Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #2062:
URL: https://github.com/apache/calcite/pull/2062#discussion_r453409732



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlOperator.java
##########
@@ -891,6 +893,15 @@ public SqlReturnTypeInference getReturnTypeInference() {
     return returnTypeInference;
   }
 
+  /**
+   * @return the {@link Strong.Policy} strategy for this operator, or null if
+   * the policy inference is implemented by a subclass override
+   * @see Strong
+   */
+  public Supplier<Strong.Policy> getStrongPolicyInference() {
+    return null;
+  }
+

Review comment:
       `@return` -> `Returns`
   `@see Strong` should have a blank line in front
   Why name it `getStrongPolicyInference` ? There is no explicit interface named a policy inference.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org