You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/19 07:28:11 UTC

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9109: IGNITE-14737 Equals predicate with multiple results from subqueries m…

alex-plekhanov commented on a change in pull request #9109:
URL: https://github.com/apache/ignite/pull/9109#discussion_r634980452



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java
##########
@@ -161,6 +161,9 @@
         @Override public void add(Object... args) {
             assert args.length == 1 : args.length;
 
+            if (holder != null)

Review comment:
       What about queries like `SELECT NAME FROM products WHERE CAT_ID = (SELECT null UNION ALL SELECT 1)`? I think we should fail on such queries too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org