You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/22 11:36:47 UTC

[GitHub] [superset] frafra opened a new issue #16781: Read MAPBOX_API_KEY from environment

frafra opened a new issue #16781:
URL: https://github.com/apache/superset/issues/16781


   All the settings are read from environment variables, except `MAPBOX_API_KEY`, which requires modifying `superset_config.py`.
   https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py
   
   https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/docs/src/pages/docs/frequently-asked-questions-page.mdx#why-is-the-map-not-visible-in-the-geospatial-visualization
   
   It would be better just to add `MAPBOX_API_KEY= get_env_variable("MAPBOX_API_KEY")` somewhere in `superset_config.py` and add `MAPBOX_API_KEY=''` in `docker/.env*` files, and update the documentation accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] frafra commented on issue #16781: Read MAPBOX_API_KEY from environment

Posted by GitBox <gi...@apache.org>.
frafra commented on issue #16781:
URL: https://github.com/apache/superset/issues/16781#issuecomment-930015146


   @Lawful2002 sure, it is yours :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Lawful2002 commented on issue #16781: Read MAPBOX_API_KEY from environment

Posted by GitBox <gi...@apache.org>.
Lawful2002 commented on issue #16781:
URL: https://github.com/apache/superset/issues/16781#issuecomment-929811289


   @frafra I would like to work on this issue if it is still open.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] frafra commented on issue #16781: Read MAPBOX_API_KEY from environment

Posted by GitBox <gi...@apache.org>.
frafra commented on issue #16781:
URL: https://github.com/apache/superset/issues/16781#issuecomment-930015146


   @Lawful2002 sure, it is yours :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Lawful2002 commented on issue #16781: Read MAPBOX_API_KEY from environment

Posted by GitBox <gi...@apache.org>.
Lawful2002 commented on issue #16781:
URL: https://github.com/apache/superset/issues/16781#issuecomment-929811289


   @frafra I would like to work on this issue if it is still open.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org