You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "magic-peach (via GitHub)" <gi...@apache.org> on 2026/07/11 15:01:34 UTC
[PR] Use time.monotonic() for duration checks in databricks provider [airflow]
magic-peach opened a new pull request, #69758:
URL: https://github.com/apache/airflow/pull/69758
Duration and timeout comparisons should use `time.monotonic()` instead of `time.time()` to be immune to system clock adjustments (NTP, DST, etc.). This aligns with the project coding standard documented in AGENTS.md.
Changes:
- `databricks_base.py`: Replace `time.time()` with `time.monotonic()` in Azure metadata cache TTL checks (both sync and async versions)
- `databricks.py` trigger: Replace `time.time()` with `time.monotonic()` in the polling loop timeout check
- `mixins.py`: Replace `time.time()` with `time.monotonic()` in SQL statement execution timeout checks, and fix grammar error in comment ("important steps; if a query takes to log" → "important step; if a query takes too long")
Note: `time.time()` is correctly retained for token expiry comparisons (lines 337, 378, 640, 1021, 1066) because those compare against wall-clock Unix timestamps received from the Databricks server.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
Drafted-by: Claude Code (Opus 4.7) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use time.monotonic() for duration checks in databricks provider [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #69758: Use time.monotonic() for duration checks in databricks provider
URL: https://github.com/apache/airflow/pull/69758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use time.monotonic() for duration checks in databricks provider [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #69758:
URL: https://github.com/apache/airflow/pull/69758#issuecomment-4946973060
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use time.monotonic() for duration checks in databricks provider [airflow]
Posted by "Vamsi-klu (via GitHub)" <gi...@apache.org>.
Vamsi-klu commented on PR #69758:
URL: https://github.com/apache/airflow/pull/69758#issuecomment-5014062860
I verified the current head against `main`. The serialized deferrable deadline needs to remain epoch-based in both `_handle_deferrable_execution` and the trigger, while the Azure metadata TTL and synchronous polling duration can remain monotonic.
I can provide a cherry-pickable patch with fail-on-revert coverage for expiry creation, cached expiry comparison, synchronous polling, deferrable deadline creation, and trigger deadline consumption. I do not currently have write access to this head branch; please let me know whether a fork commit or branch access is preferred.
---
Drafted-by: Codex (GPT-5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org