You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mikhail Khludnev (JIRA)" <ji...@apache.org> on 2016/03/25 08:23:25 UTC

[jira] [Commented] (SOLR-8902) ReturnFields can return fields that were not requested

    [ https://issues.apache.org/jira/browse/SOLR-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211546#comment-15211546 ] 

Mikhail Khludnev commented on SOLR-8902:
----------------------------------------

I walked around ReturnFields recently (while work on SOLR-8208), was a little bit wondered, but considered SOLR-7622 as a feature after all, and now I found SOLR-8902 issue description is a little controversial. Sadly, I don't fully understand what's about and what all this {{wantsFoo}}, {{okFoo}} means. I just want to make sure that this fix is solid with existing.  

> ReturnFields can return fields that were not requested
> ------------------------------------------------------
>
>                 Key: SOLR-8902
>                 URL: https://issues.apache.org/jira/browse/SOLR-8902
>             Project: Solr
>          Issue Type: Bug
>          Components: Response Writers
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 6.1, trunk
>
>         Attachments: SOLR-8902.diff
>
>
> It looks like something changed that now returns all fields requested from lucene, not just the ones request from solr.
> This is the difference between 'fields' and 'okFieldNames' in SolrReturnFields.
> The logic here:
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java#L141
> adds all the 'fields' to 'okFieldName'
> I think that should be removed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org