[GitHub] [lucene-solr] madrob commented on a change in pull request #1563: LUCENE-9394: fix and suppress warnings

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#discussion_r438975730



##########
File path: lucene/core/src/test/org/apache/lucene/analysis/TestCharArraySet.java
##########
@@ -61,15 +61,17 @@ public void testNonZeroOffset() {
   public void testObjectContains() {
     CharArraySet set = new CharArraySet(10, true);
     Integer val = Integer.valueOf(1);
+    @SuppressWarnings("deprecation")
+    Integer val1 = new Integer(1);

Review comment:
       Add a comment that we're explicitly avoiding the Integer cache, and an `assertNotSame(val, val1)`?

##########
File path: lucene/spatial-extras/src/test/org/apache/lucene/spatial/prefix/HeatmapFacetCounterTest.java
##########
@@ -33,11 +33,7 @@
 import org.locationtech.spatial4j.context.SpatialContext;
 import org.locationtech.spatial4j.context.SpatialContextFactory;
 import org.locationtech.spatial4j.distance.DistanceUtils;
-import org.locationtech.spatial4j.shape.Circle;
-import org.locationtech.spatial4j.shape.Point;
-import org.locationtech.spatial4j.shape.Rectangle;
-import org.locationtech.spatial4j.shape.Shape;
-import org.locationtech.spatial4j.shape.SpatialRelation;
+import org.locationtech.spatial4j.shape.*;

Review comment:
       wildcard import

##########
File path: lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/RandomizedShapeTestCase.java
##########
@@ -183,106 +179,4 @@ private void _assertIntersect(String msg, SpatialRelation expected, Shape a, Sha
     }
   }
 
-  protected void assertEqualsRatio(String msg, double expected, double actual) {

Review comment:
       There appear to be more unused methods in this class, why did we keep them but not these?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org