[GitHub] [netbeans] juneau001 commented on pull request #5866: NETBEANS-4035: CDI Bean as Named is not listed in xhtml for selection

["juneau001 (via GitHub)" <gi...@apache.org>]

juneau001 commented on PR #5866:
URL: https://github.com/apache/netbeans/pull/5866#issuecomment-1543268543

   > @juneau001 I gave the latest version of this PR a spin and noticed warnings and also saw the commit validation test failing here. I had a quick look and indeed the layer file has duplicate entries. This patch fixes this:
   > 
   > [warnings.patch.zip](https://github.com/apache/netbeans/files/11445353/warnings.patch.zip)
   > 
   > If I'm not mistaken though, this is still not quite correct, as I was in a JavaEE project and asked NetBeans to add a JakarataEE beans.xml, but got a JavaEE one. While that is correct for the project, it is strange to see two template entries then. Anyway, maybe the patch can help to push this further.
   
   Thanks for the patch...I will apply it.  Actually, the fix in this PR does not repair the incorrect beans.xml namespaces.  The code changes in this PR repair the code completion issues only.  I am working on another PR that will repair XHTML namespaces for Jakarta Faces 4+.  I can also look into repairing the beans.xml namespaces. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists