[GitHub] liupc commented on a change in pull request #23438: [SPARK-26525]Fast release ShuffleBlockFetcherIterator on completion of the iteration

[GitBox <gi...@apache.org>]

liupc commented on a change in pull request #23438: [SPARK-26525]Fast release ShuffleBlockFetcherIterator on completion of the iteration
URL: https://github.com/apache/spark/pull/23438#discussion_r251234781
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
 ##########
 @@ -212,6 +214,9 @@ final class ShuffleBlockFetcherIterator(
         logWarning("Failed to cleanup shuffle fetch temp file " + file.path())
       }
     }
+    // Unregister completion callbacks to avoid memory leak for ShuffleBlockFetcherIterator
+    // contains lots of metadata about MapStatus
+    context.removeTaskCompletionListener(cleanupListener)
 
 Review comment:
   @HyukjinKwon got it, Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org