[GitHub] [spark] LuciferYang commented on a diff in pull request #43191: [SPARK-45389][SQL][HIVE] Correct MetaException matching rule on getting partition metadata

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43191:
URL: https://github.com/apache/spark/pull/43191#discussion_r1342149333


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -536,7 +536,7 @@ private[client] class Shim_v2_0 extends Shim with Logging {
         recordHiveCall()
         hive.getPartitionsByNames(table, partNames.asJava)
       } catch {
-        case ex: InvocationTargetException if ex.getCause.isInstanceOf[MetaException] =>
+        case ex: HiveException if ex.getCause.isInstanceOf[MetaException] =>

Review Comment:
   Perhaps there is no test case that covers this exceptional scenario.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org