You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/28 18:08:58 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #19864: Fixing failing test test_external_executor_id_present_for_fork_run_task
khalidmammadov opened a new pull request #19864:
URL: https://github.com/apache/airflow/pull/19864
This test case was broken due to missing self.dagbag and dag_id=test_run_fork_has_external_executor_id.
This PR fixes the issue and makes the test inline with the suite logic/setup and preserves test case's objective.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-986235133
@potiuk done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-986052905
can you please rebase it @khalidmammadov ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-986282371
@potiuk done.
I have also got some draft fix for test_logging_with_run_task_subprocess. Will do PR when finished, busy with MyPy work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-981157722
There is only one test case (test_logging_with_run_task_subprocess) left unfixed in this suite (tests.cli.commands.test_task_command.TestLogsfromTaskRunCommand) so we can un-quarantine it and that is dependent on https://github.com/apache/airflow/pull/19845. Which will help me to fix that last remaining test case as well.
Additionally, some test cases in this suite also being fixed by https://github.com/apache/airflow/pull/19858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-981147699
cc: @uranusjr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19864:
URL: https://github.com/apache/airflow/pull/19864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] khalidmammadov commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-982685028
This one also related https://github.com/apache/airflow/pull/19132 and from the same file but not one of the quarantined ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19864: Fixing failing quarantined test cases in test_task_command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19864:
URL: https://github.com/apache/airflow/pull/19864#issuecomment-986276223
Those look good. However - can we just remove the `quarantined` markers from the class and add them to the two test methods that are still failiing? this will make only the two failing tests skipped @khalidmammadov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org