You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/05/05 00:43:15 UTC
[GitHub] bookkeeper pull request #138: BOOKKEEPER-1008: Netty 4.1
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/138
BOOKKEEPER-1008: Netty 4.1
Added more ref-count fixes from yahoo-4.3 branch on top of #116
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper netty-4.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit 037ec026472d24d4ec4f607392fbf26c6327387f
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-09-04T22:58:43Z
Close bk connections when handling exceptions
(cherry picked from commit 270835b33c512cfe6e33216cf7e9284c1af556f6)
commit a347a22b4ef6117e5be358c2f3616202971a8181
Author: Kishore Kasi Udayashankar <ku...@salesforce.com>
Date: 2017-02-13T19:50:22Z
BOOKKEEPER-1008 Move to Netty4.1
commit 0ae9b59e93ac90246098d7bd95b6e3eeb2c59027
Author: Kishore Kasi Udayashankar <ku...@salesforce.com>
Date: 2017-05-01T20:55:18Z
Addressing review comments
- Use Netty 4.1.9
- Do not include classifier for Netty dependency. This will force using
Nio in linux platform
- fix testWriteGaps testcase failure
commit b4a24450c3056e04414b32752a86d70bf47ad0a5
Author: Matteo Merli <mm...@apache.org>
Date: 2017-05-03T00:49:11Z
Addressed comments from @revans2 and switched to netty-all dependency
(cherry picked from commit 6b9e1e4f53078808999ea5fed0bd7e6c893635db)
commit 28f5e9adc7d48850f7fd42c63dc01c12fa811227
Author: Kishore Kasi Udayashankar <ku...@salesforce.com>
Date: 2017-05-03T07:21:57Z
Addressing ref count issues in LedgerHandleAdv and PendingAddOp
commit e056096c156a374e75bb6acd552e0f5e7d413155
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-03-24T19:26:39Z
Avoid ByteBuf.duplicate() in deserialization of addEntry
commit 1b0fc56293f1cd76dee559bf93045edee23011aa
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-05-20T15:10:53Z
Fixed ref counting release on read errors
commit cbd669e0ebd4ed600720d688097c40d789ca8e6b
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-06-10T17:13:50Z
Fixed ref count when reading last confirmed op
commit 9d296789fc7c02322b544b193f80c425f03f68d8
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-06-18T21:15:03Z
Release buffer after error
commit 99b37374e9bd93f7435d84ee067ab4e31cff184c
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-06-28T04:32:25Z
Release buffer when exception is thrown
commit 8c79ffadc900b5209be61d1a143960ce3be24aa1
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-07-08T13:47:25Z
Fixed issue with releasing null buffer
commit 005a02df37e7d95837d4ac4ff4f50dd2c3d9a3ed
Author: Matteo Merli <mm...@apache.org>
Date: 2017-05-04T20:50:18Z
Ensure the buffer to send is retained while we are connecting to bookie
commit 03988c6b12a7dff26bf586d717fd01959771bce5
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-07-03T05:31:04Z
Added DoubleByteBuf instead of using CompositeByteBuf
commit 0967741e3ea0bd477345e9c988284078c264566d
Author: Matteo Merli <mm...@yahoo-inc.com>
Date: 2015-08-20T22:37:27Z
Ensure entries for same ledger are sent in order on the same connection, to minimize reordering
commit e1acf7e79766f6521cd6c23dc68d5e37cc3f9d4a
Author: Matteo Merli <mm...@apache.org>
Date: 2017-05-05T00:16:53Z
Wait for all requests to complete before releasing buffer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Sorry @merlimat I will checkout your latest changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/138
@kishorekasi @jvrao @revans2 @sijie @eolivelli
All the tests are passing properly with epoll event loop on linux. I have already applied most of the ref-count fixes from yahoo branch as well. This contains all fixes from Kishore as well.
Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #138: BOOKKEEPER-1008: Netty 4.1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Great work @merlimat and @kishorekasi!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by jvrao <gi...@git.apache.org>.
Github user jvrao commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Nice work!! Finally everything is passing. :) Great news.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
I am seeing this errors
{code}
Tests run: 120, Failures: 0, Errors: 44, Skipped: 0, Time elapsed: 64.802 sec <<< FAILURE! - in org.apache.bookkeeper.client.BookieRecoveryTest
ensurePasswordUsedForOldLedgers[0](org.apache.bookkeeper.client.BookieRecoveryTest) Time elapsed: 0.126 sec <<< ERROR!
java.lang.NoClassDefFoundError: org/apache/bk_v4_1_0/bookkeeper/client/BookKeeper$DigestType
at org.apache.bookkeeper.client.BookieRecoveryTest.ensurePasswordUsedForOldLedgers(BookieRecoveryTest.java:905)
Caused by: java.lang.ClassNotFoundException: org.apache.bk_v4_1_0.bookkeeper.client.BookKeeper$DigestType
at org.apache.bookkeeper.client.BookieRecoveryTest.ensurePasswordUsedForOldLedgers(BookieRecoveryTest.java:905)
{code}
{code}
testAsyncBookieRecoveryToSpecificBookie[9](org.apache.bookkeeper.client.BookieRecoveryTest) Time elapsed: 2.223 sec <<< ERROR!
java.lang.IllegalStateException: failed to create a child event loop
at org.apache.bookkeeper.client.BookieRecoveryTest.setUp(BookieRecoveryTest.java:113)
Caused by: io.netty.channel.ChannelException: eventfd() failed: Too many open files
at org.apache.bookkeeper.client.BookieRecoveryTest.setUp(BookieRecoveryTest.java:113)
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/138
@eolivelli Thanks, it should fix the error you were seing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by jiazhai <gi...@git.apache.org>.
Github user jiazhai commented on the issue:
https://github.com/apache/bookkeeper/pull/138
Passed all the test on my Mac in 17 min.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #138: BOOKKEEPER-1008: Netty 4.1
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/138
@merlimat After checking out the latest commit I am able to run the full test suite in 23min without errors
findbugs and rat are OK !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---