You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/01/03 17:22:23 UTC
[GitHub] [incubator-livy] fenimore opened a new pull request #270: VCL-1018
Specify batch session ID in documentation
fenimore opened a new pull request #270: VCL-1018 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270
## What changes were proposed in this pull request?
The API documentation suggests that the batch query endpoint returns a session_id, I found this confusing because elsewhere the documentation specifies querying with the batch_id.
## How was this patch tested?
no code change
## JIRA ticket
I saw an open ticket in JIRA for the documentation terminology -- I thought this was appropriate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] jerryshao commented on issue #270: [LIVY-138]
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
jerryshao commented on issue #270: [LIVY-138] Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-572836559
LIVY-138 is a fixed JIRA for different issues, it is not proper to link to a fixed JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore commented on issue #270: LIVY-138 Specify
batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore commented on issue #270: LIVY-138 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-572577121
> Hi fenimore,
>
> VCL-1018 is related to the Apache VCL project rather than the Apache Incubator Livy project. If you want your pull request to be associated with a JIRA issue, you'll need to find one associated with Livy. I work on the VCL project and am not familiar with the Livy project. So, I don't know if they use JIRA to track issues or not.
>
> -Josh
woops sorry about that, I was looking for documentation tickets on the JIRA and VCL appeared in the search, I wasn't really familiar with the acronyms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore edited a comment on issue #270: VCL-1018
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore edited a comment on issue #270: VCL-1018 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-570638519
https://issues.apache.org/jira/browse/LIVY-138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] jfthomps commented on issue #270: VCL-1018 Specify
batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
jfthomps commented on issue #270: VCL-1018 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-570653807
Hi fenimore,
VCL-1018 is related to the Apache VCL project rather than the Apache Incubator Livy project. If you want your pull request to be associated with a JIRA issue, you'll need to find one associated with Livy. I work on the VCL project and am not familiar with the Livy project. So, I don't know if they use JIRA to track issues or not.
-Josh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore commented on issue #270: [LIVY-138]
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore commented on issue #270: [LIVY-138] Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-573127373
ok sorry about that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore closed pull request #270: [LIVY-138]
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore closed pull request #270: [LIVY-138] Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore commented on issue #270: VCL-1018 Specify
batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore commented on issue #270: VCL-1018 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-570638519
https://issues.apache.org/jira/browse/VCL-1018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] fenimore commented on issue #270: [LIVY-138]
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
fenimore commented on issue #270: [LIVY-138] Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-572577456
I should probably create a new ticket for this, but I don't think I'll be creating an account on this JIRA -- so if a new ticket is what it takes I'll probably close this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] jerryshao commented on issue #270: VCL-1018
Specify batch session ID in documentation
Posted by GitBox <gi...@apache.org>.
jerryshao commented on issue #270: VCL-1018 Specify batch session ID in documentation
URL: https://github.com/apache/incubator-livy/pull/270#issuecomment-570974019
@fenimore please change your PR title to follow what other Livy PR did, also please link to the correct Livy JIRA (or create a new one if not existed). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services