You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/29 02:39:30 UTC

[GitHub] [pulsar] congbobo184 commented on a change in pull request #11135: [Broker] Fix broker dispatch byte rate limiter.

congbobo184 commented on a change in pull request #11135:
URL: https://github.com/apache/pulsar/pull/11135#discussion_r660238529



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
##########
@@ -276,8 +278,10 @@ public synchronized void readMoreEntries() {
         }
     }
 
-    protected int calculateNumOfMessageToRead(int currentTotalAvailablePermits) {
+    // left pair is messagesToRead, right pair is bytesToRead
+    protected MutablePair<Integer, Integer> calculateToRead(int currentTotalAvailablePermits) {

Review comment:
       it only the calculate result, not internal number.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org