You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2023/10/23 12:12:18 UTC
[PR] [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers [incubator-celeborn]
SteNicholas opened a new pull request, #2027:
URL: https://github.com/apache/incubator-celeborn/pull/2027
### What changes were proposed in this pull request?
Remove unnecessary increment index of `Master#timeoutDeadWorkers`.
### Why are the changes needed?
Increment index of `Master#timeoutDeadWorkers` is unnecessary.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2027:
URL: https://github.com/apache/incubator-celeborn/pull/2027#issuecomment-1775079860
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2027?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2027](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2027?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5705329) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/655d5762ca1b9271af892cfe369fe0c69cd135e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (655d576) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
- Coverage 46.74% 46.72% -0.01%
==========================================
Files 165 165
Lines 10531 10531
Branches 959 959
==========================================
- Hits 4922 4920 -2
- Misses 5284 5285 +1
- Partials 325 326 +1
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2027?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...born/common/identity/DefaultIdentityProvider.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2027?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2lkZW50aXR5L0RlZmF1bHRJZGVudGl0eVByb3ZpZGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2027/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2027:
URL: https://github.com/apache/incubator-celeborn/pull/2027#discussion_r1368574838
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -266,7 +266,7 @@ private[celeborn] class Master(
logDebug(s"Client $address got disassociated.")
}
- def executeWithLeaderChecker[T](context: RpcCallContext, f: => T): Unit =
+ private def executeWithLeaderChecker[T](context: RpcCallContext, f: => T): Unit =
Review Comment:
please keep the existing access scope of methods, other changes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2027: [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers
URL: https://github.com/apache/incubator-celeborn/pull/2027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2027: [MINOR] Remove unnecessary increment index of Master#timeoutDeadWorkers
URL: https://github.com/apache/incubator-celeborn/pull/2027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org