You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2005/10/22 17:13:25 UTC
svn_wc_external_item_dup parameter names
There's a mismatch between the prototype and the definition of
svn_wc_external_item_dup(), introduced in r16772 and ported to 1.3.x in r16791:
> Index: branches/1.3.x/subversion/include/svn_wc.h
> ===================================================================
[...]
> /**
> + * Return a duplicate of @a item, allocated in @a pool. No part of the new
> + * item will be shared with @a item.
Here: "item".
> + *
> + * @since New in 1.3.
> + */
> +svn_wc_external_item_t *
> +svn_wc_external_item_dup (const svn_wc_external_item_t *entry,
Here: "entry".
> + apr_pool_t *pool);
> Index: branches/1.3.x/subversion/libsvn_wc/util.c
> ===================================================================
[...]
> +svn_wc_external_item_t *
> +svn_wc_external_item_dup (const svn_wc_external_item_t *item, apr_pool_t *pool)
Here "item".
It's legal C but obviously not what we meant. I have no preference on which
way to resolve it.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_wc_external_item_dup parameter names
Posted by David James <ja...@gmail.com>.
On 10/23/05, Julian Foad <ju...@btopenworld.com> wrote:
> David James wrote:
> >
> > Good catch, Julian! I really appreciate your attention to detail.
> >
> > I've fixed this in r16929 by using the parameter name "item"
> > consistently. Should we nominate this for backport as well?
>
> Thanks. Yes, I think so - please do.
I've nominated r16929 for backport.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Re: svn_wc_external_item_dup parameter names
Posted by Julian Foad <ju...@btopenworld.com>.
David James wrote:
>
> Good catch, Julian! I really appreciate your attention to detail.
>
> I've fixed this in r16929 by using the parameter name "item"
> consistently. Should we nominate this for backport as well?
Thanks. Yes, I think so - please do.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn_wc_external_item_dup parameter names
Posted by David James <ja...@gmail.com>.
On 10/22/05, Julian Foad <ju...@btopenworld.com> wrote:
> There's a mismatch between the prototype and the definition of
> svn_wc_external_item_dup(), introduced in r16772 and ported to 1.3.x in r16791:
>
> > Index: branches/1.3.x/subversion/include/svn_wc.h
> > ===================================================================
> [...]
> > /**
> > + * Return a duplicate of @a item, allocated in @a pool. No part of the new
> > + * item will be shared with @a item.
>
> Here: "item".
>
> > + *
> > + * @since New in 1.3.
> > + */
> > +svn_wc_external_item_t *
> > +svn_wc_external_item_dup (const svn_wc_external_item_t *entry,
>
> Here: "entry".
>
> > + apr_pool_t *pool);
>
> > Index: branches/1.3.x/subversion/libsvn_wc/util.c
> > ===================================================================
> [...]
> > +svn_wc_external_item_t *
> > +svn_wc_external_item_dup (const svn_wc_external_item_t *item, apr_pool_t *pool)
>
> Here "item".
>
>
> It's legal C but obviously not what we meant. I have no preference on which
> way to resolve it.
Good catch, Julian! I really appreciate your attention to detail.
I've fixed this in r16929 by using the parameter name "item"
consistently. Should we nominate this for backport as well?
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james