You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directory.apache.org by Stefan Seelmann <ma...@stefan-seelmann.de> on 2016/07/03 21:21:49 UTC

Re: [VOTE] Apache Directory Studio 2.0.0.v20160628-M11 release

On 06/29/2016 12:14 PM, Emmanuel L�charny wrote:
> Le 29/06/16 � 00:20, Stefan Seelmann a �crit :
>> Hi all,
>>
>> here is a vote on a new Studio release.
> 
> Testing it atm. A few remarks :
> 
> * on Mac OSX, there is an issue with the JVM. Since Apple totally fucked
> up and decided to not provide anymore a JVM, we have an issue when
> starting Studio. We get a message like "The JVM shared library does not
> contain the JNI_CreateJavaVM symbol". This can be fixed by tuning the
> ApacheDirectoryStudio.app/Contents/Info.plist file, like :
> 
>     <array>
>       <!-- to use a specific Java version (instead of the platform's
> default) uncomment one of the following options,
>                                         or add a VM found via
> $/usr/libexec/java_home -V
>         <string>-vm</string>
>        
> <string>/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Commands/java</string>
> 
>       -->
>       <!-- The following line has been uncomented and the path to the
> existing JVM added -->
>       <string>-vm</string>
>      
> <string>/Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/bin/java</string>
>       <string>-keyring</string>
>       <string>~/.eclipse_keyring</string>
>       <string>-showlocation</string>
>     </array>
> 
> This is obviously a real pain in the neck. I think we can get it fixed
> but I don't see how. As soon as we have installers, plus a part in teh
> README telling users how to build the installers, we can simply ignore
> this issue (but it should be documented in teh README and on the web site)

I remember the problems on Mac. The FAQ site has a hint how to find the
JDK path and how to add it to ApacheDirectoryStudio.ini (which seems to
be easier than editing Info.plist). I think it makes sense to put that
information to the Mac download page too.

https://directory.apache.org/studio/faqs.html#how-to-set-the-java-vm-to-use

> * The place where the produced packages are put is not correct :
> https://dist.apache.org/repos/dist/dev/directory/studio/2.0.0.v20160628-M11/2.0.0.v20160628-M11/
> instead of
> https://dist.apache.org/repos/dist/dev/directory/studio/2.0.0.v20160628-M11/.
> Not such a big deal, it can be fixed for the next build.

Ok, that is easy to fix

> * We don't have the installers to test. Packages for all the platforms
> we suport should be created (.dmg, .deb, .exe, .rpm). I have created the
> DMG following the README in the /tools/Mac OS X DMG/README doco, I think
> creating all the other installers should be part of the release being
> voted. Note that the installer works well, and teh version it installs
> doe snot have teh same problem I faced upper.

We have issue https://issues.apache.org/jira/browse/DIRSTUDIO-1022, but
to be honest I'm not very motivated to generate the installers.

* I'm not sure if generation of .dmg works well on Linux
* Generating .dmg, .deb, .rpm, .exe requries native tools
* It costs time to create an maintain those installer scripts. Should we
reuse installers-maven-plugin from ApacheDS?
* The additional .deb and .exe (32 bit and 64 bit) increase the release
by another 480 MB
* The installers need to be tested (in theory .deb and .rpm can be
automated...)

The Tycho build now nicely generates zip/tgz for Linux/Mac/Windows out
of the box on all platforms. I think our users don't need installers but
can unpack a zip/tgz.

> * The copyright licence on the logo is from 2006-2015. It should be 2016.
> 
> * The Notice.txt file has an outdated header too : "Apache Directory
> Studio Copyright 2007-2014 The Apache Software Foundation"
> 
> * The LICENSE.txt file needs a serious review :
> - there are mixed license between nlog4j and slf4j :
> 
> "Apache Directory Studio bundles a copy of SLF4J API Module, which is
> distributed under the
> following license:
> -------------------------------------------------------------------------------
>     NLOG4J License
> 
> Copyright (c) 2004-2006 SLF4J.ORG
> Copyright (c) 2004-2006 QOS.ch
> 
> "
> 
> - we should include the license for slf4j
> (http://www.slf4j.org/license.html).

I see. I updated the legal files for Fortress and Kerby but was too lazy
to check them in Studio, I'll update them.

Thanks Emmanuel for the review and finding all the issues.

Kind Regards,
Stefan