You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Pelladi Gabor (JIRA)" <ji...@apache.org> on 2012/05/22 15:57:41 UTC

[jira] [Created] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Pelladi Gabor created WW-3824:
---------------------------------

             Summary: Ajax request encoding case is different than non-ajax encoding
                 Key: WW-3824
                 URL: https://issues.apache.org/jira/browse/WW-3824
             Project: Struts 2
          Issue Type: Bug
          Components: Dispatch Filter
    Affects Versions: 2.3.3
            Reporter: Pelladi Gabor
            Priority: Trivial


This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
Note that the first is upper-case, the other is lower-case.
In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285514#comment-13285514 ] 

Hudson commented on WW-3824:
----------------------------

Integrated in Struts2 #483 (See [https://builds.apache.org/job/Struts2/483/])
    WW-3824 changes encoding definition to uppercase for Ajax requests to match specification (Revision 1344143)

     Result = SUCCESS
lukaszlenart : 
Files : 
* /struts/struts2/trunk/core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java

                
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 2.3.5
>
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart resolved WW-3824.
-------------------------------

    Resolution: Fixed
      Assignee: Lukasz Lenart

Patch applied, thanks for reporting!
                
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 2.3.5
>
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285495#comment-13285495 ] 

Lukasz Lenart commented on WW-3824:
-----------------------------------

ech.. "Finished: SUCCESS" but reports as unstable :P
                
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 2.3.5
>
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285491#comment-13285491 ] 

Hudson commented on WW-3824:
----------------------------

Integrated in Struts2 #482 (See [https://builds.apache.org/job/Struts2/482/])
    WW-3824 changes encoding definition to uppercase for Ajax requests to match specification (Revision 1344134)

     Result = UNSTABLE
lukaszlenart : 
Files : 
* /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java

                
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Assignee: Lukasz Lenart
>            Priority: Trivial
>             Fix For: 2.3.5
>
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart updated WW-3824:
------------------------------

    Fix Version/s: 2.3.5
    
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Priority: Trivial
>             Fix For: 2.3.5
>
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WW-3824) Ajax request encoding case is different than non-ajax encoding

Posted by "Pelladi Gabor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pelladi Gabor updated WW-3824:
------------------------------

    Attachment: WW-3824.diff
    
> Ajax request encoding case is different than non-ajax encoding
> --------------------------------------------------------------
>
>                 Key: WW-3824
>                 URL: https://issues.apache.org/jira/browse/WW-3824
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch Filter
>    Affects Versions: 2.3.3
>            Reporter: Pelladi Gabor
>            Priority: Trivial
>         Attachments: WW-3824.diff
>
>
> This is related to WW-3796: Error at setting character encoding if the parameters have been already read.
> For all non-ajax requests, the default encoding is "UTF-8", defined in struts.properties: struts.i18n.encoding
> For all ajax requests, the encoding is forced to "utf-8", defined in Dispatcher.java, line 684.
> Note that the first is upper-case, the other is lower-case.
> In the applyEncoding method, the encoding is compared case sensitive, so UTF-8 and utf-8 are not equal.
> The patch changes utf-8 to UTF-8. The reference in the source comment at that line: http://www.w3.org/TR/XMLHttpRequest/#the-send-method says: "Let encoding be UTF-8."
> This way the applyEncoding method will function as one would expect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira