You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/15 13:14:26 UTC
[GitHub] [rocketmq] XiaoyiPeng opened a new pull request #3489: DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.
XiaoyiPeng opened a new pull request #3489:
URL: https://github.com/apache/rocketmq/pull/3489
**Make sure set the target branch to `develop`**
## What is the purpose of the change
1.fix(consumer): DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.
2.fix(consumer): Handle RejectedExecutionException that may be encountered when the call ConsumeMessageConcurrentlyService#submitConsumeRequestLater
## Brief changelog
1.Replace unlimited size `this.consumeRequestQueue = new LinkedBlockingQueue<Runnable>()` with bounded queues when creating `ConsumeMessageConcurrentlyService#consumeExecutor,` in order to make `DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax)` to work.
2. `consumeExecutor.submit(consumeRequest)` may throw an RejectedExecutionException in below code:
```
private void submitConsumeRequestLater(final ConsumeRequest consumeRequest) {
this.scheduledExecutorService.schedule(new Runnable() {
@Override
public void run() {
ConsumeMessageConcurrentlyService.this.consumeExecutor.submit(consumeRequest);
}
}, 5000, TimeUnit.MILLISECONDS);
}
```
but the program does not handle it.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3489: DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3489:
URL: https://github.com/apache/rocketmq/pull/3489#issuecomment-968920603
[](https://coveralls.io/builds/44265278)
Coverage decreased (-0.05%) to 55.049% when pulling **7dc5d773f5602ab1671294ba722c78dfbb4459fd on XiaoyiPeng:push_consumer** into **4b8b307901da19a1e562c883adc1bdaf8e111cfb on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] XiaoyiPeng closed pull request #3489: DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.
Posted by GitBox <gi...@apache.org>.
XiaoyiPeng closed pull request #3489:
URL: https://github.com/apache/rocketmq/pull/3489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org