[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers

["Dan Hecht (Code Review)" <ge...@cloudera.org>]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT_MSG
Commit Message:

Line 34:   already_unregistered=false, and cancel).
Given the discussion in the change review, do we still believe this to be the requirement? i.e. wasn't the thought to make it illegal to close the exchange before the sender finishes?  (though I need to think about this more).


http://gerrit.cloudera.org:8080/#/c/2305/5/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:

Line 45: /// higher will increase the size of the stream cache (which is 48 bytes per receiver).
In the case it doesn't outlive all calls to FindRecvrOrWait() for that stream ID, what is the consequence?  (And I think worth noting that in the comment).


-- 
To view, visit http://gerrit.cloudera.org:8080/2305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1734992c7199b9dd4b03afca5372022051b6fbd
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes