You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/22 02:15:01 UTC
[GitHub] [beam] epicfaace opened a new pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
epicfaace opened a new pull request #11788:
URL: https://github.com/apache/beam/pull/11788
Add Python 3.8 postcommit tests.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652628585
@epicfaace , Actually, I will send out Dataflow changes first, then we can add postcommit tests, this way it would be easier to separate and merge the changes, especially if some tests don't pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637085217
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] epicfaace commented on a change in pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
epicfaace commented on a change in pull request #11788:
URL: https://github.com/apache/beam/pull/11788#discussion_r429283691
##########
File path: .test-infra/jenkins/README.md
##########
@@ -84,6 +84,7 @@ Beam Jenkins overview page: [link](https://builds.apache.org/view/A-D/view/Beam/
| beam_PostCommit_Python35 | [cron](https://builds.apache.org/job/beam_PostCommit_Python35), [phrase](https://builds.apache.org/job/beam_PostCommit_Python35_PR/) | `Run Python 3.5 PostCommit` | [](https://builds.apache.org/job/beam_PostCommit_Python35) |
| beam_PostCommit_Python36 | [cron](https://builds.apache.org/job/beam_PostCommit_Python36), [phrase](https://builds.apache.org/job/beam_PostCommit_Python36_PR/) | `Run Python 3.6 PostCommit` | [](https://builds.apache.org/job/beam_PostCommit_Python36) |
| beam_PostCommit_Python37 | [cron](https://builds.apache.org/job/beam_PostCommit_Python37), [phrase](https://builds.apache.org/job/beam_PostCommit_Python37_PR/) | `Run Python 3.7 PostCommit` | [](https://builds.apache.org/job/beam_PostCommit_Python37) |
+| beam_PostCommit_Python38 | [cron](https://builds.apache.org/job/beam_PostCommit_Python38), [phrase](https://builds.apache.org/job/beam_PostCommit_Python38_PR/) | `Run Python 3.7 PostCommit` | [](https://builds.apache.org/job/beam_PostCommit_Python38) |
Review comment:
```suggestion
| beam_PostCommit_Python38 | [cron](https://builds.apache.org/job/beam_PostCommit_Python38), [phrase](https://builds.apache.org/job/beam_PostCommit_Python38_PR/) | `Run Python 3.8 PostCommit` | [](https://builds.apache.org/job/beam_PostCommit_Python38) |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653132163
@kamilwu I anticipate that some of the postcommit tests may be failing, possibly due to outdated IO libraries. If so, you could help identify, isolate and investigate failures, and we could temporarily exclude failing tests in PostCommits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637862976
Run Python 3.6 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652523655
BTW, we have released Py38 containers for Dataflow yesterday. I am also curious if these tests now pass, I'll give them a try in next couple of hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] epicfaace commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-632723409
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654111381
I see that PostCommit suite has passed on Python 3.8, so it seems all IO libraries are compatible (unless we skipped some of tests, but I don't think so)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652618865
Hey @epicfaace, I rebased your first 3 commits on top of masters and did some changes to enable Dataflow postcommits: https://github.com/apache/beam/compare/master...tvalentyn:additions_to_11788_rebased.
I think we can combine the two sets of commits and rerun the suite. I can add my commits to this branch, or create a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637862778
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654458386
@epicfaace nvm, I was able to merge the branches in the UI, but had to redo it since I merged incorrectly first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lazylynx commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
lazylynx commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-636999532
@tvalentyn Thanks for notification.
It would be better to merge this PR first and then I will update my work according to the upstream changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib removed a comment on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib removed a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637002052
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654406007
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637863213
Failed with:
```
16:39:16
16:39:16 FAILURE: Build failed with an exception.
16:39:16
16:39:16 * What went wrong:
16:39:16 Could not determine the dependencies of task ':python38PostCommit'.
16:39:16 > Task with path ':sdks:python:test-suites:portable:py38:postCommitPy38' not found in root project 'beam'.
16:39:16
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-634117541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653252897
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637073561
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653131533
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #11788:
URL: https://github.com/apache/beam/pull/11788#discussion_r450417158
##########
File path: sdks/python/test-suites/direct/py38/build.gradle
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.module' }
+applyPythonNature()
+
+// Required to setup a Python 3 virtualenv and task names.
+pythonVersion = '3.8'
+apply from: '../common.gradle'
+
+def pythonDir = "${rootDir}/sdks/python"
+
+task hdfsIntegrationTest {
Review comment:
It would be nice to move this to common.gradle (we can do it in another change to avoid having to re-test this). Glad to see postcommits passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-635675870
/cc @tvalentyn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-635696787
@epicfaace Thanks for your initiative to help with Python 3.8.
Please see the discussion on introducing high-priority/low priority versions: https://lists.apache.org/thread.html/r643cae69e5be136e6bca75bf896991fa313f79623ca056271588c87d%40%3Cdev.beam.apache.org%3E
cc: Yoshiki (@lazylynx) who is was also working on this and may have some thoughts how to best integrate these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637093914
@epicfaace looks like the newly added postcommit fails, PTAL: https://builds.apache.org/job/beam_PostCommit_Python38_PR/1/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn merged pull request #11788:
URL: https://github.com/apache/beam/pull/11788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637002052
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637852060
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637002257
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654419277
@epicfaace could you please address the merge conflict in .github/PULL_REQUEST_TEMPLATE.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637855187
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn edited a comment on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn edited a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652618865
Hey @epicfaace, I rebased your first 3 commits on top of master and did some changes to enable Dataflow postcommits: https://github.com/apache/beam/compare/master...tvalentyn:additions_to_11788_rebased.
I think we can combine the two sets of commits and rerun the suite. I can add my commits to this branch, or create a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
ibzib commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637073369
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn edited a comment on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn edited a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653132163
@kamilwu I anticipate that some of the postcommit tests may be failing, possibly due to outdated IO libraries. If so, you could help identify, isolate and investigate failures, and we could temporarily exclude failing tests in 3.8 PostCommits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654111796
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653260583
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] epicfaace commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-632724234
Run Python PreCommit
Run Python 3.7 PostCommit
Run Python 3.8 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] epicfaace commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652584570
I'll finish it up today!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn removed a comment on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn removed a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653131533
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] epicfaace commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-652621627
@tvalentyn I believe it should be ready now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn edited a comment on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn edited a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-654458386
@epicfaace nvm, I was able to merge the branches in the UI, but had to redo it since I merged incorrectly first.
All tests passed earlier today on d12f3c2970c73c625f6ae0067988dae2301ee723. Remaining commit does not affect tests. Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11788: [BEAM-9785] Add Python 3.8 postcommit tests
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-637702442
```
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
Setting status of 7764d54a3a5deedcec7c39e2195ae7fb33f6b169 to FAILURE with url https://builds.apache.org/job/beam_PostCommit_Python38_PR/1/ and message: 'FAILURE
'
```
This may be happening because sdks:python:test-suites:dataflow:py38:postCommitIT does not include any tests. You can try commenting that suite out for now. I expect Dataflow to support Python 3.8 before next Beam release is cut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org