You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 07:05:41 UTC
[GitHub] [airflow] uranusjr opened a new pull request #18934: Implement API generator and use it on Connection
uranusjr opened a new pull request #18934:
URL: https://github.com/apache/airflow/pull/18934
See #15072, cc @ephraimbuddy
It turns out Connexion performs argument introspection to decide what arguments to pass to an endpoint (a bit like pytest fixtures), so we can't actually make the functions _too_ generic. For example, we must have a parameter named `connection_id` in various Connection endpoints, but that's obvious specific to Connection and cannot be refactored out. So this two-layer approach is the best I can come up with for now.
I'm not actually convinced myself if this is a good idea (it feels like a ton of architecture that makes code more difficult to understand), but at least now we have something to think about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-946431400
> Any thoughts on the general approach taken here? Again, the abstraction implemented here is not really affected by what OpenAPI implementation we use.
👍 I like the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#discussion_r732707875
##########
File path: airflow/api_connexion/endpoints/base.py
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Container, Dict, Generic, Iterable, List, Optional, Tuple, Type, TypeVar
+
+from flask import request
+from marshmallow import Schema, ValidationError
+from sqlalchemy.orm import Query
+from sqlalchemy.sql import ColumnElement
+
+from airflow import settings
+from airflow._vendor.connexion import NoContent
+from airflow.api_connexion.exceptions import AlreadyExists, BadRequest, NotFound
+from airflow.api_connexion.parameters import check_limit, format_parameters
+from airflow.compat.functools import cached_property
+from airflow.models.base import Base
+
+M = TypeVar("M", bound=Base)
+
+
+class Endpoints(Generic[M]):
+ """Base endpoint implementation generator class for an abstract resource.
+
+ This class does not assume the data storage backend, and a resource must
+ implement various methods to make things work. If the resource is a
+ SQLAlchemy model, see ``ModelEndpoints``.
+ """
+
+ resource_name: str # Name of the resource for display in error messages etc.
+ instance_index: List[str] # List keys to uniquely select an instance.
Review comment:
This is not a list of indices, but describing _an_ index (in the database sense) to select a unique instance out for comparison (another name I briefly considered was `primary_key`). But the name is indeed difficult to understand, maybe I'll change it to something like `unique_instance_fields`. Suggestions are definitely much welcomed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #18934:
URL: https://github.com/apache/airflow/pull/18934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#discussion_r732657948
##########
File path: airflow/api_connexion/endpoints/base.py
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Container, Dict, Generic, Iterable, List, Optional, Tuple, Type, TypeVar
+
+from flask import request
+from marshmallow import Schema, ValidationError
+from sqlalchemy.orm import Query
+from sqlalchemy.sql import ColumnElement
+
+from airflow import settings
+from airflow._vendor.connexion import NoContent
+from airflow.api_connexion.exceptions import AlreadyExists, BadRequest, NotFound
+from airflow.api_connexion.parameters import check_limit, format_parameters
+from airflow.compat.functools import cached_property
+from airflow.models.base import Base
+
+M = TypeVar("M", bound=Base)
+
+
+class Endpoints(Generic[M]):
+ """Base endpoint implementation generator class for an abstract resource.
+
+ This class does not assume the data storage backend, and a resource must
+ implement various methods to make things work. If the resource is a
+ SQLAlchemy model, see ``ModelEndpoints``.
+ """
+
+ resource_name: str # Name of the resource for display in error messages etc.
+ instance_index: List[str] # List keys to uniquely select an instance.
Review comment:
```suggestion
instance_indices: List[str] # List keys to uniquely select an instance.
```
Wondering if it should be plural?
##########
File path: airflow/api_connexion/endpoints/base.py
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Container, Dict, Generic, Iterable, List, Optional, Tuple, Type, TypeVar
+
+from flask import request
+from marshmallow import Schema, ValidationError
+from sqlalchemy.orm import Query
+from sqlalchemy.sql import ColumnElement
+
+from airflow import settings
+from airflow._vendor.connexion import NoContent
+from airflow.api_connexion.exceptions import AlreadyExists, BadRequest, NotFound
+from airflow.api_connexion.parameters import check_limit, format_parameters
+from airflow.compat.functools import cached_property
+from airflow.models.base import Base
+
+M = TypeVar("M", bound=Base)
+
+
+class Endpoints(Generic[M]):
+ """Base endpoint implementation generator class for an abstract resource.
+
+ This class does not assume the data storage backend, and a resource must
+ implement various methods to make things work. If the resource is a
+ SQLAlchemy model, see ``ModelEndpoints``.
+ """
+
+ resource_name: str # Name of the resource for display in error messages etc.
+ instance_index: List[str] # List keys to uniquely select an instance.
+
+ # A list of two-tuples mapping a field's internal name to external (as seen by the user).
Review comment:
Dictionary, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942255674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942255674
https://github.com/tiangolo/fastapi ? 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942283541
Connexion seems to have found some new life recently: zalando/connexion#1429
But this PR (and the idea of turning the API implementation into structured classes) isn't really that related to Connexion or whatever OpenAPI tool we use; it was mentioned because the implementation hit some restrictions in Connexion and had to avoid some encapsulation to make things work. But this actually has a "nice" side effect that makes our logic encapsulation decoupled to the OpenAPI part, and we wouldn't need to change the extracted classes when we migrate to another OpenAPI implementation. (What *will* require the class to change is if we switch away from Marshmallow, e.g. use FaskAPI.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942243756
> Connexion seems to be an abandonded project, so we might want to migrate off to some thing else instead of putting more time in to using it?
I'd quite agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-946395002
Any thoughts on the general approach taken here? Again, the abstraction implemented here is not really affected by what OpenAPI implementation we use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#discussion_r732708130
##########
File path: airflow/api_connexion/endpoints/base.py
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Container, Dict, Generic, Iterable, List, Optional, Tuple, Type, TypeVar
+
+from flask import request
+from marshmallow import Schema, ValidationError
+from sqlalchemy.orm import Query
+from sqlalchemy.sql import ColumnElement
+
+from airflow import settings
+from airflow._vendor.connexion import NoContent
+from airflow.api_connexion.exceptions import AlreadyExists, BadRequest, NotFound
+from airflow.api_connexion.parameters import check_limit, format_parameters
+from airflow.compat.functools import cached_property
+from airflow.models.base import Base
+
+M = TypeVar("M", bound=Base)
+
+
+class Endpoints(Generic[M]):
+ """Base endpoint implementation generator class for an abstract resource.
+
+ This class does not assume the data storage backend, and a resource must
+ implement various methods to make things work. If the resource is a
+ SQLAlchemy model, see ``ModelEndpoints``.
+ """
+
+ resource_name: str # Name of the resource for display in error messages etc.
+ instance_index: List[str] # List keys to uniquely select an instance.
+
+ # A list of two-tuples mapping a field's internal name to external (as seen by the user).
Review comment:
Right, I changed the implementation but forgot to update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#discussion_r732715776
##########
File path: airflow/api_connexion/endpoints/base.py
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Container, Dict, Generic, Iterable, List, Optional, Tuple, Type, TypeVar
+
+from flask import request
+from marshmallow import Schema, ValidationError
+from sqlalchemy.orm import Query
+from sqlalchemy.sql import ColumnElement
+
+from airflow import settings
+from airflow._vendor.connexion import NoContent
+from airflow.api_connexion.exceptions import AlreadyExists, BadRequest, NotFound
+from airflow.api_connexion.parameters import check_limit, format_parameters
+from airflow.compat.functools import cached_property
+from airflow.models.base import Base
+
+M = TypeVar("M", bound=Base)
+
+
+class Endpoints(Generic[M]):
+ """Base endpoint implementation generator class for an abstract resource.
+
+ This class does not assume the data storage backend, and a resource must
+ implement various methods to make things work. If the resource is a
+ SQLAlchemy model, see ``ModelEndpoints``.
+ """
+
+ resource_name: str # Name of the resource for display in error messages etc.
+ instance_index: List[str] # List keys to uniquely select an instance.
Review comment:
Cool. I prefer the `unique_instance_fields`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942259291
https://github.com/p1c2u/openapi-core is on my list to look at, but it's still a fairly small project so I wouldn't feel happy with Airflow using it unless we also got one of us to have co-maintainer on the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-1009472803
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-947588100
Let's hear from others before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-947161459
Should be ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942243756
> Connexion seems to be an abandonded project, so we might want to migrate off to some thing else instead of putting more time in to using it?
I'd quite agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942086691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-980035992
New release with flask2 support -> https://github.com/zalando/connexion/releases/tag/2.10.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-947568672
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942277808
> Sadly not -- (at least last time I looked) FastAPI is the inverse of what we want when it comes to the schema -- FastAPI creates the OpenAPI schema from the views/models etc, where as we want to specify the schema up front and the implement it
Oh yeah, forgot about that !! :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942283541
Connexion seems to have found some new life recently: zalando/connexion#1429
But this PR (and the idea of turning the API implementation into structured classes) isn't really that related to Connexion or whatever OpenAPI tool we use; it was mentioned because the implementation hit some restrictions in Connexion and had to avoid some encapsulation to make things work. But this actually has a "nice" side effect that makes our logic encapsulation decoupled to the OpenAPI part, and we wouldn't need to change the extracted classes when we migrate to another OpenAPI implementation. (What *will* require the class to change is if we switch away from Marshmallow, e.g. use FaskAPI.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-942086691
Connexion seems to be an abandonded project, so we might want to migrate off to some thing else instead of putting more time in to using it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RobbeSneyders commented on pull request #18934: Implement API generator and use it on Connection
Posted by GitBox <gi...@apache.org>.
RobbeSneyders commented on pull request #18934:
URL: https://github.com/apache/airflow/pull/18934#issuecomment-944282013
@Ruwann and I have recently joined as maintainers on Connexion, specifically because it is the only mature API-first Python framework. Let us know if we can help out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org