You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/09/22 01:17:14 UTC
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #889: PHOENIX-6148 & PHOENIX-6149 : [SchemaExtractionTool] DDL parsing exception in Phoenix…
gjacoby126 commented on a change in pull request #889:
URL: https://github.com/apache/phoenix/pull/889#discussion_r492429045
##########
File path: phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaExtractionProcessor.java
##########
@@ -203,6 +203,9 @@ protected String extractCreateViewDDL(PTable table) throws SQLException {
private String generateCreateViewDDL(String columnInfoString, String baseTableFullName,
String whereClause, String pSchemaName, String pTableName) {
String viewFullName = SchemaUtil.getQualifiedTableName(pSchemaName, pTableName);
+ if(Character.isDigit(pTableName.charAt(0))) {
Review comment:
Is this a bug in SchemaUtil.getQualfiedTableName? This seems like something we shouldn't have to repeat everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org