You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/09/21 07:00:10 UTC
[PR] fix(deploy, v1.3): enable CORS on RustFS so browsers can fetch presigned URLs [texera]
mengw15 opened a new pull request, #8623:
URL: https://github.com/apache/texera/pull/8623
### What changes were proposed in this PR?
Backport of #8562 to `release/v1.3`: a clean cherry-pick of its squash commit, no adaptations — five added lines across the single-node compose file, the dev compose file and the Helm chart's `extraEnv`.
This branch needs it because #8550 already made RustFS the default object store here. RustFS sends no CORS headers unless `RUSTFS_CORS_ALLOWED_ORIGINS` is set (its reflective default was removed as CVE-2026-46685), while MinIO sent them by default — so without this change a v1.3 deployment renders no dataset file preview: the browser's cross-origin fetch of the presigned URL is blocked and the preview stays in its loading state.
Opened manually by the v1.3 release manager: the automated fast path cherry-picked this cleanly and then pushed it straight to `release/v1.3`, where the Merge Queue ruleset rejected the push (`GH013`, [run 35305278774](https://github.com/apache/texera/actions/runs/35305278774)). The Actions-app bypass meant to unblock that path (#8379) was never created — asfyaml rejects an `Integration` bypass actor — and the failing job's notification 403s for want of `pull-requests: write`, so the loss left neither a backport PR nor a comment on #8562. The `release/v1.2` backport did get a PR (#8585, merged) only because it took the other code path. See #8377.
Source: af6e0fdd96f44c1d575278b9fd12ed61ce6a8640
### Any related issues, documentation, discussions?
Backport of #8562. Originally linked #8557.
### How was this PR tested?
The change is identical to #8562 (configuration only, no application code); the backport tree is verified byte-identical to cherry-picking the squash commit onto `release/v1.3`. Release-branch CI runs the full matrix on this PR, including the integration jobs that provision RustFS.
### Was this PR authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code (claude-opus-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deploy, v1.3): enable CORS on RustFS so browsers can fetch presigned URLs [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8623:
URL: https://github.com/apache/texera/pull/8623#issuecomment-5756684499
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8623?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.06%. Comparing base ([`5036097`](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3eb6ec6`](https://app.codecov.io/gh/apache/texera/commit/3eb6ec6c081e71d3e4b278734b7bbec69468f326?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release/v1.3 #8623 +/- ##
===============================================
Coverage 94.06% 94.06%
Complexity 4808 4808
===============================================
Files 1194 1194
Lines 48601 48601
Branches 5860 5860
===============================================
Hits 45718 45718
Misses 1429 1429
Partials 1454 1454
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.10% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.00% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.75% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.81% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.18% <ø> (ø)` | | Carriedforward from [5036097](https://app.codecov.io/gh/apache/texera/commit/503609751eadad3ef88dfd9b8488ae9f7df131ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8623?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deploy, v1.3): enable CORS on RustFS so browsers can fetch presigned URLs [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8623:
URL: https://github.com/apache/texera/pull/8623#issuecomment-5756631564
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deploy, v1.3): enable CORS on RustFS so browsers can fetch presigned URLs [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #8623:
URL: https://github.com/apache/texera/pull/8623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org