You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jesse Long (JIRA)" <ji...@apache.org> on 2012/08/30 11:35:08 UTC

[jira] [Commented] (WICKET-4626) WicketFilter unify the filterPath

    [ https://issues.apache.org/jira/browse/WICKET-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444826#comment-13444826 ] 

Jesse Long commented on WICKET-4626:
------------------------------------

This patch has broken the ability to pre-set the filter path using the setFilterPath() method. In my use case, my WicketFilter is created from within another Filter. This Filter then sets the filterPath using the setFilterPath() method.

Now, after this patch, WicketFilter.init() calls setFilterPath() for a second time, causing an IllegalStateException (see top of setFilterPath() method).
                
> WicketFilter unify the filterPath
> ---------------------------------
>
>                 Key: WICKET-4626
>                 URL: https://issues.apache.org/jira/browse/WICKET-4626
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>            Reporter: Darryl L. Miles
>            Assignee: Martin Grigorov
>             Fix For: 6.0.0
>
>         Attachments: 0001-WICKET-4626-WicketFilter-unify-the-filterPath.patch
>
>
> WICKET-4626 WicketFilter unify the filterPath
> Use of getter/setter internally to limit read/writes to filterPath         
> field location.
> Removed lazy initialization code from main code path.
> Provide a new method #canonicaliseFilterPath(String) to convert
> "/wicket/" into "wicket/" as expected internally and maybe used by
> unit tests to further validate correct values for filterPath.
> Added unit test for this new method and use method in setter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira