[GitHub] [samza] asautins opened a new pull request, #1671: Fix scope of caches for DirDiffUtil.areSameFile

["asautins (via GitHub)" <gi...@apache.org>]

asautins opened a new pull request, #1671:
URL: https://github.com/apache/samza/pull/1671

   ## Summary
   
   Fix scope of owner and group name caches in `DirDiffUtil.areSameFile`
   
   ## Detail
   
   In #1669 the caches were scoped incorrectly and will be re-created each time `areSameFile` called.  Scoping the group and name caches outside of the lambda to cache as expected.
   
   ## Test
      * Added unit test `TestDirDiffUtilAreSameFile.testAreSameFile_Cache` to verify the caches are working as expected.
      * `./gradlew check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat merged pull request #1671: Fix scope of caches for DirDiffUtil.areSameFile

["mynameborat (via GitHub)" <gi...@apache.org>]

mynameborat merged PR #1671:
URL: https://github.com/apache/samza/pull/1671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org